This is an archive of the discontinued LLVM Phabricator instance.

Differential D59505

Fix flat-error-unsupported-gpu-hsa test
ClosedPublic

Authored by aganea on Mar 18 2019, 12:13 PM.

Details

Reviewers
arsenm
Commits
rG9af9f500d197: Fix flat-error-unsupported-gpu-hsa test
rL356400: Fix flat-error-unsupported-gpu-hsa test
Summary

Tested in both Debug & Release builds, on both Windows and WSL/Ubuntu.

Diff Detail

Repository
rL LLVM

Event Timeline

aganea created this revision.Mar 18 2019, 12:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2019, 12:13 PM
Herald added subscribers: llvm-commits, nhaehnle, wdng, jvesely. · View Herald Transcript
arsenm accepted this revision.Mar 18 2019, 12:28 PM

LGTM

This revision is now accepted and ready to land.Mar 18 2019, 12:28 PM
Closed by commit rL356400: Fix flat-error-unsupported-gpu-hsa test (authored by aganea). · Explain WhyMar 18 2019, 12:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
CodeGen/
AMDGPU/
2 lines

Diff 191146

llvm/trunk/test/CodeGen/AMDGPU/flat-error-unsupported-gpu-hsa.ll

; RUN: not llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx600 -filetype=obj -o /dev/null %s 2>&1 | FileCheck -check-prefix=ERROR %s ; RUN: not llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx600 -filetype=obj -o /dev/null %s 2>&1 | FileCheck -check-prefix=ERROR %s
; RUN: not llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx600 -filetype=obj -o /dev/null %s 2>&1 | FileCheck -check-prefix=ERROR %s ; RUN: not llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx600 -filetype=obj -o /dev/null %s 2>&1 | FileCheck -check-prefix=ERROR %s
; RUN: llc -mtriple=amdgcn-amd-amdhsa -o - %s | FileCheck -check-prefix=HSA-DEFAULT %s ; RUN: llc -mtriple=amdgcn-amd-amdhsa -o - %s | FileCheck -check-prefix=HSA-DEFAULT %s
; RUN: not llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx600 -filetype=obj -o /dev/null %s 2>&1 | FileCheck -check-prefix=ERROR %s ; RUN: not llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx600 -filetype=obj -o /dev/null %s 2>&1 | FileCheck -check-prefix=ERROR %s
; Flat instructions should not select if the target device doesn't ; Flat instructions should not select if the target device doesn't
; support them. The default device should be able to select for HSA. ; support them. The default device should be able to select for HSA.
; ERROR: LLVM ERROR: Cannot select: t{{[0-9]+}}: i32,ch = load<(volatile load 4 from %ir.flat.ptr.load)> ; ERROR: LLVM ERROR: Cannot select: {{0x[0-9,a-f]+|t[0-9]+}}: i32,ch = load<(volatile load 4 from %ir.flat.ptr.load)>
; HSA-DEFAULT: flat_load_dword ; HSA-DEFAULT: flat_load_dword
define amdgpu_kernel void @load_flat_i32(i32* %flat.ptr) { define amdgpu_kernel void @load_flat_i32(i32* %flat.ptr) {
%load = load volatile i32, i32* %flat.ptr, align 4 %load = load volatile i32, i32* %flat.ptr, align 4
ret void ret void
} }