This is an archive of the discontinued LLVM Phabricator instance.

Differential D5941

[libcxx] XFAIL all currently failing libc++ tests for linux.
ClosedPublic

Authored by EricWF on Oct 23 2014, 12:57 PM.

Details

Reviewers
mclow.lists
danalbert
jroelofs
Commits
rGe608aed22b05: [libcxx] XFAIL all currently failing libc++ tests for linux.
rCXX220512: [libcxx] XFAIL all currently failing libc++ tests for linux.
rL220512: [libcxx] XFAIL all currently failing libc++ tests for linux.
Summary

Pretty please? We now have a significant number of builders that test libc++. I really want those builders to be green.
Most of these failures are due to differences in locale data, including those in regex. I will continue working on fixing the locale and regex tests but there is no consensus on what the correct direction to go.

Since the builders display a list of XFAIL tests they are by no means hidden. It just means they are expected failures. Now unexpected failures won't get mixed in with well known and expected failures.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 15343.Oct 23 2014, 12:57 PM
EricWF retitled this revision from to [libcxx] XFAIL all currently failing libc++ tests for linux..
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added reviewers: mclow.lists, danalbert, jroelofs.
EricWF added a subscriber: Unknown Object (MLST).
jroelofs edited edge metadata.Oct 23 2014, 1:28 PM

Not that I want it to be any harder to get this patch in (I'm a huge fan of it!), but... it might be useful to have bugzilla tickets for them.

danalbert edited edge metadata.Oct 23 2014, 1:30 PM

Could you mark them as XFAIL: linux-gnu instead? The linux target also matches Android (some of these might be failing on Android as well, but I'll worry about those myself).

EricWF updated this revision to Diff 15346.Oct 23 2014, 1:53 PM
EricWF edited edge metadata.

Changed XFAIL: linux to XFAIL: linux-gnu. @jroelofs I'll file to separate bugs. One for the test/localization failures and another for the test/re failures. I think filing a bug per test case would be excessive.

EricWF added a comment.Oct 23 2014, 2:04 PM

Bugs tracking these tests are:

  • PR21364: Localization tests
  • PR21363: Regex tests.
danalbert accepted this revision.Oct 23 2014, 2:24 PM
danalbert edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Oct 23 2014, 2:24 PM
EricWF closed this revision.Oct 23 2014, 2:28 PM

Revision Contents

PathSize
test/
localization/
locale.categories/
category.collate/
locale.collate.byname/
5 lines
category.monetary/
locale.money.get/
locale.money.get.members/
3 lines
locale.money.put/
locale.money.put.members/
3 lines
locale.moneypunct.byname/
6 lines
category.numeric/
locale.nm.put/
facet.num.put.members/
3 lines
category.time/
locale.time.get.byname/
3 lines
3 lines
3 lines
3 lines
locale.time.put.byname/
3 lines
locale.time.put/
locale.time.put.members/
3 lines
facet.numpunct/
locale.numpunct.byname/
3 lines
3 lines
re/
re.alg/
re.alg.match/
3 lines
3 lines
3 lines
re.alg.search/
3 lines
3 lines
3 lines
3 lines
re.traits/
3 lines
3 lines

Diff 15346

test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp

Context not available.
// has any difference from "C" collation. But I do believe I'm picking // has any difference from "C" collation. But I do believe I'm picking
// up the OS's collation files. // up the OS's collation files.
// TODO investigation needed.
// Glibc seems to collate files differently from the way Apple's C library does
// it.
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <string> #include <string>
#include <cassert> #include <cassert>
Context not available.

test/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp

Context not available.
// iter_type get(iter_type b, iter_type e, bool intl, ios_base& iob, // iter_type get(iter_type b, iter_type e, bool intl, ios_base& iob,
// ios_base::iostate& err, long double& v) const; // ios_base::iostate& err, long double& v) const;
// TODO For zh_CN GLIBC puts the negative sign after the currency symbol.
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <ios> #include <ios>
#include <streambuf> #include <streambuf>
Context not available.

test/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp

Context not available.
// iter_type put(iter_type s, bool intl, ios_base& f, char_type fill, // iter_type put(iter_type s, bool intl, ios_base& f, char_type fill,
// long double units) const; // long double units) const;
// TODO For zh_CN GLIBC puts the negative sign after the currency symbol.
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <ios> #include <ios>
#include <streambuf> #include <streambuf>
Context not available.

test/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp

Context not available.
// charT thousands_sep() const; // charT thousands_sep() const;
// Failure related to GLIBC's use of U00A0 as mon_thousands_sep
// and U002E as mon_decimal_point.
// TODO: U00A0 should be investigated.
// Possibly related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16006
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <limits> #include <limits>
#include <cassert> #include <cassert>
Context not available.

test/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp

Context not available.
// iter_type put(iter_type s, ios_base& iob, char_type fill, long double v) const; // iter_type put(iter_type s, ios_base& iob, char_type fill, long double v) const;
// TODO GLIBC uses a different string for positive and negative NAN numbers.
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <ios> #include <ios>
#include <cassert> #include <cassert>
Context not available.

test/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp

Context not available.
// iter_type get(iter_type s, iter_type end, ios_base& f, // iter_type get(iter_type s, iter_type end, ios_base& f,
// ios_base::iostate& err, tm *t, char format, char modifier = 0) const; // ios_base::iostate& err, tm *t, char format, char modifier = 0) const;
// TODO: investigation needed
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <cassert> #include <cassert>
#include "test_iterators.h" #include "test_iterators.h"
Context not available.

test/localization/locale.categories/category.time/locale.time.get.byname/get_one_wide.pass.cpp

Context not available.
// iter_type get(iter_type s, iter_type end, ios_base& f, // iter_type get(iter_type s, iter_type end, ios_base& f,
// ios_base::iostate& err, tm *t, char format, char modifier = 0) const; // ios_base::iostate& err, tm *t, char format, char modifier = 0) const;
// TODO: investigation needed
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <cassert> #include <cassert>
#include "test_iterators.h" #include "test_iterators.h"
Context not available.

test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp

Context not available.
// get_weekday(iter_type s, iter_type end, ios_base& str, // get_weekday(iter_type s, iter_type end, ios_base& str,
// ios_base::iostate& err, tm* t) const; // ios_base::iostate& err, tm* t) const;
// TODO: investigation needed
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <cassert> #include <cassert>
#include "test_iterators.h" #include "test_iterators.h"
Context not available.

test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday_wide.pass.cpp

Context not available.
// get_weekday(iter_type s, iter_type end, ios_base& str, // get_weekday(iter_type s, iter_type end, ios_base& str,
// ios_base::iostate& err, tm* t) const; // ios_base::iostate& err, tm* t) const;
// TODO: investigation needed
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <cassert> #include <cassert>
#include "test_iterators.h" #include "test_iterators.h"
Context not available.

test/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp

Context not available.
// ~time_put_byname(); // ~time_put_byname();
// }; // };
// TODO: investigation needed
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <cassert> #include <cassert>
#include "test_iterators.h" #include "test_iterators.h"
Context not available.

test/localization/locale.categories/category.time/locale.time.put/locale.time.put.members/put2.pass.cpp

Context not available.
// iter_type put(iter_type s, ios_base& str, char_type fill, const tm* t, // iter_type put(iter_type s, ios_base& str, char_type fill, const tm* t,
// char format, char modifier = 0) const; // char format, char modifier = 0) const;
// TODO: investigation needed
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <cassert> #include <cassert>
#include "test_iterators.h" #include "test_iterators.h"
Context not available.

test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp

Context not available.
// string grouping() const; // string grouping() const;
// TODO: investigation needed
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <cassert> #include <cassert>
Context not available.

test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp

Context not available.
// char_type thousands_sep() const; // char_type thousands_sep() const;
// TODO: investigation needed
// XFAIL: linux-gnu
#include <locale> #include <locale>
#include <cassert> #include <cassert>
Context not available.

test/re/re.alg/re.alg.match/basic.pass.cpp

Context not available.
// const basic_regex<charT, traits>& e, // const basic_regex<charT, traits>& e,
// regex_constants::match_flag_type flags = regex_constants::match_default); // regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
// XFAIL: linux-gnu
#include <regex> #include <regex>
#include <cassert> #include <cassert>
Context not available.

test/re/re.alg/re.alg.match/ecma.pass.cpp

Context not available.
// const basic_regex<charT, traits>& e, // const basic_regex<charT, traits>& e,
// regex_constants::match_flag_type flags = regex_constants::match_default); // regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
// XFAIL: linux-gnu
#include <regex> #include <regex>
#include <cassert> #include <cassert>
Context not available.

test/re/re.alg/re.alg.match/extended.pass.cpp

Context not available.
// const basic_regex<charT, traits>& e, // const basic_regex<charT, traits>& e,
// regex_constants::match_flag_type flags = regex_constants::match_default); // regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
// XFAIL: linux-gnu
#include <regex> #include <regex>
#include <cassert> #include <cassert>
Context not available.

test/re/re.alg/re.alg.search/awk.pass.cpp

Context not available.
// const basic_regex<charT, traits>& e, // const basic_regex<charT, traits>& e,
// regex_constants::match_flag_type flags = regex_constants::match_default); // regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
// XFAIL: linux-gnu
#include <regex> #include <regex>
#include <cassert> #include <cassert>
Context not available.

test/re/re.alg/re.alg.search/basic.pass.cpp

Context not available.
// const basic_regex<charT, traits>& e, // const basic_regex<charT, traits>& e,
// regex_constants::match_flag_type flags = regex_constants::match_default); // regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
// XFAIL: linux-gnu
#include <regex> #include <regex>
#include <cassert> #include <cassert>
Context not available.

test/re/re.alg/re.alg.search/ecma.pass.cpp

Context not available.
// const basic_regex<charT, traits>& e, // const basic_regex<charT, traits>& e,
// regex_constants::match_flag_type flags = regex_constants::match_default); // regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
// XFAIL: linux-gnu
#include <regex> #include <regex>
#include <cassert> #include <cassert>
Context not available.

test/re/re.alg/re.alg.search/extended.pass.cpp

Context not available.
// const basic_regex<charT, traits>& e, // const basic_regex<charT, traits>& e,
// regex_constants::match_flag_type flags = regex_constants::match_default); // regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
// XFAIL: linux-gnu
#include <regex> #include <regex>
#include <cassert> #include <cassert>
Context not available.

test/re/re.traits/lookup_collatename.pass.cpp

Context not available.
// string_type // string_type
// lookup_collatename(ForwardIterator first, ForwardIterator last) const; // lookup_collatename(ForwardIterator first, ForwardIterator last) const;
// TODO: investigation needed
// XFAIL: linux-gnu
#include <regex> #include <regex>
#include <iterator> #include <iterator>
#include <cassert> #include <cassert>
Context not available.

test/re/re.traits/translate_nocase.pass.cpp

Context not available.
// XFAIL: with_system_lib=x86_64-apple-darwin11 // XFAIL: with_system_lib=x86_64-apple-darwin11
// XFAIL: with_system_lib=x86_64-apple-darwin12 // XFAIL: with_system_lib=x86_64-apple-darwin12
// TODO: investigation needed
// XFAIL: linux-gnu
#include <regex> #include <regex>
#include <cassert> #include <cassert>
Context not available.