This is an archive of the discontinued LLVM Phabricator instance.

[LLD][COFF] Improve checkFailIfMismatch
ClosedPublic

Authored by aganea on Mar 15 2019, 6:07 AM.

Details

Summary

As suggested here, defer a call to toString(File) until it's really needed (if there's an error)

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

aganea created this revision.Mar 15 2019, 6:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2019, 6:07 AM
rnk added a comment.Mar 15 2019, 2:33 PM

I think this is a good change. The map on the side is less string-ly typed now. We should wait for @ruiu since it was his review feedback.

Ping. @ruiu, is this what you had in mind, regarding https://reviews.llvm.org/D58910#1425484 ?

ruiu accepted this revision.Mar 26 2019, 12:45 PM

LGTM

COFF/DriverUtils.cpp
708

Remove this variable and directly use "cmd-line" instead.

This revision is now accepted and ready to land.Mar 26 2019, 12:45 PM
This revision was automatically updated to reflect the committed changes.
aganea marked an inline comment as done.