Page MenuHomePhabricator

[libcxx] XFAIL all currently failing libc++ tests for linux.
ClosedPublic

Authored by EricWF on Oct 23 2014, 12:57 PM.

Details

Summary

Pretty please? We now have a significant number of builders that test libc++. I really want those builders to be green.
Most of these failures are due to differences in locale data, including those in regex. I will continue working on fixing the locale and regex tests but there is no consensus on what the correct direction to go.

Since the builders display a list of XFAIL tests they are by no means hidden. It just means they are expected failures. Now unexpected failures won't get mixed in with well known and expected failures.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 15343.Oct 23 2014, 12:57 PM
EricWF retitled this revision from to [libcxx] XFAIL all currently failing libc++ tests for linux..
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added reviewers: mclow.lists, danalbert, jroelofs.
EricWF added a subscriber: Unknown Object (MLST).
jroelofs edited edge metadata.Oct 23 2014, 1:28 PM

Not that I want it to be any harder to get this patch in (I'm a huge fan of it!), but... it might be useful to have bugzilla tickets for them.

danalbert edited edge metadata.Oct 23 2014, 1:30 PM

Could you mark them as XFAIL: linux-gnu instead? The linux target also matches Android (some of these might be failing on Android as well, but I'll worry about those myself).

EricWF updated this revision to Diff 15346.Oct 23 2014, 1:53 PM
EricWF edited edge metadata.

Changed XFAIL: linux to XFAIL: linux-gnu. @jroelofs I'll file to separate bugs. One for the test/localization failures and another for the test/re failures. I think filing a bug per test case would be excessive.

Bugs tracking these tests are:

  • PR21364: Localization tests
  • PR21363: Regex tests.
danalbert accepted this revision.Oct 23 2014, 2:24 PM
danalbert edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Oct 23 2014, 2:24 PM
EricWF closed this revision.Oct 23 2014, 2:28 PM