Page MenuHomePhabricator

[Reproducers] Support capturing a reproducer without an explicit path.
ClosedPublic

Authored by JDevlieghere on Mar 11 2019, 6:26 PM.

Details

Summary

Tablegen doesn't support options that serve both as flags and as arguments taking a value. I noticed this when doing the tablegen rewrite, but forgot that that affected my reproducer flags. This patch adds another flag, namely --capture-path that allows the user to explicitly specify a path for the reproducer. In reality I expect this to be mostly used for testing, but it could be useful regardless.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

JDevlieghere created this revision.Mar 11 2019, 6:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2019, 6:26 PM
Herald added a subscriber: teemperor. · View Herald Transcript
davide accepted this revision.Mar 12 2019, 9:25 AM
This revision is now accepted and ready to land.Mar 12 2019, 9:25 AM
This revision was automatically updated to reflect the committed changes.