Page MenuHomePhabricator

Delete x86_64 ShadowCallStack support
ClosedPublic

Authored by vlad.tsyrklevich on Mar 6 2019, 11:11 AM.

Details

Summary

ShadowCallStack on x86_64 suffered from the same racy security issues as
Return Flow Guard and had performance overhead as high as 13% depending
on the benchmark. x86_64 ShadowCallStack was always an experimental
feature and never shipped a runtime required to support it, as such
there are no expected downstream users.

Diff Detail

Event Timeline

Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptMar 6 2019, 11:11 AM
Herald added subscribers: llvm-commits, Restricted Project, cfe-commits and 4 others. · View Herald Transcript
pcc accepted this revision.Mar 6 2019, 11:28 AM

Thanks for cleaning this up.

clang/docs/ShadowCallStack.rst
23 ↗(On Diff #189541)

Should we keep a link to the Clang 7.0.1 docs?

This revision is now accepted and ready to land.Mar 6 2019, 11:28 AM
  • Keep x86_64 doc link
This revision was automatically updated to reflect the committed changes.