Page MenuHomePhabricator

[sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either
ClosedPublic

Authored by mstorsjo on Mar 5 2019, 3:40 AM.

Details

Summary

The TraceLoggingProvider.h header does work with clang-cl in general these days (contrary to when PR32021 was filed originally), but when compiled in 32 bit x86 mode, with the -Z7 flag, compilation fails with the following error:

fatal error: error in backend: assembler label '' can not be undefined

Diff Detail

Event Timeline

mstorsjo created this revision.Mar 5 2019, 3:40 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 5 2019, 3:40 AM
Herald added subscribers: Restricted Project, jdoerfert, kubamracek. · View Herald Transcript
hans accepted this revision.Mar 5 2019, 4:25 AM

Thanks!

This revision is now accepted and ready to land.Mar 5 2019, 4:25 AM
This revision was automatically updated to reflect the committed changes.