This is an archive of the discontinued LLVM Phabricator instance.

Differential D58958

[sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either
ClosedPublic

Authored by mstorsjo on Mar 5 2019, 3:40 AM.

Details

Reviewers
hans
rnk
Commits
rG826624f00a8c: [sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either
rL355397: [sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either
rCRT355397: [sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either
Summary

The TraceLoggingProvider.h header does work with clang-cl in general these days (contrary to when PR32021 was filed originally), but when compiled in 32 bit x86 mode, with the -Z7 flag, compilation fails with the following error:

fatal error: error in backend: assembler label '' can not be undefined

Diff Detail

Event Timeline

mstorsjo created this revision.Mar 5 2019, 3:40 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 5 2019, 3:40 AM
Herald added subscribers: Restricted Project, jdoerfert, kubamracek. · View Herald Transcript
hans accepted this revision.Mar 5 2019, 4:25 AM

Thanks!

This revision is now accepted and ready to land.Mar 5 2019, 4:25 AM
Closed by commit rCRT355397: [sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either (authored by mstorsjo). · Explain WhyMar 5 2019, 4:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
sanitizer_common/
2 lines

Diff 189303

lib/sanitizer_common/sanitizer_common.h

Show First 20 Lines • Show All 798 Lines • ▼ Show 20 Linesenum AndroidApiLevel {
ANDROID_NOT_ANDROID = 0, ANDROID_NOT_ANDROID = 0,
ANDROID_KITKAT = 19, ANDROID_KITKAT = 19,
ANDROID_LOLLIPOP_MR1 = 22, ANDROID_LOLLIPOP_MR1 = 22,
ANDROID_POST_LOLLIPOP = 23 ANDROID_POST_LOLLIPOP = 23
}; };
void WriteToSyslog(const char *buffer); void WriteToSyslog(const char *buffer);
#if defined(SANITIZER_WINDOWS) && defined(_MSC_VER) #if defined(SANITIZER_WINDOWS) && defined(_MSC_VER) && !defined(__clang__)
#define SANITIZER_WIN_TRACE 1 #define SANITIZER_WIN_TRACE 1
#else #else
#define SANITIZER_WIN_TRACE 0 #define SANITIZER_WIN_TRACE 0
#endif #endif
#if SANITIZER_MAC || SANITIZER_WIN_TRACE #if SANITIZER_MAC || SANITIZER_WIN_TRACE
void LogFullErrorReport(const char *buffer); void LogFullErrorReport(const char *buffer);
#else #else
▲ Show 20 Lines • Show All 164 Lines • Show Last 20 Lines