This is an archive of the discontinued LLVM Phabricator instance.

Differential D58947

Restore ScopedUnwinding broken by D58861
AbandonedPublic

Authored by vitalybuka on Mar 4 2019, 6:12 PM.

Details

Reviewers
yln

Diff Detail

Event Timeline

vitalybuka created this revision.Mar 4 2019, 6:12 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 4 2019, 6:12 PM
Herald added subscribers: llvm-commits, Restricted Project, kubamracek. · View Herald Transcript
Harbormaster completed remote builds in B28783: Diff 189257.Mar 4 2019, 6:13 PM
vitalybuka retitled this revision from Restore logic broken by D58861 to Restore ScopedUnwinding broken by D58861.Mar 4 2019, 6:13 PM
vitalybuka abandoned this revision.Mar 4 2019, 6:33 PM

Revision Contents

PathSize
compiler-rt/
lib/
asan/
13 lines

Diff 189257

compiler-rt/lib/asan/asan_stack.cc

Show All 29 Lines
void __sanitizer::BufferedStackTrace::UnwindImpl( void __sanitizer::BufferedStackTrace::UnwindImpl(
uptr pc, uptr bp, void *context, bool request_fast, u32 max_depth) { uptr pc, uptr bp, void *context, bool request_fast, u32 max_depth) {
using namespace __asan; using namespace __asan;
size = 0; size = 0;
if (UNLIKELY(!asan_inited)) return; if (UNLIKELY(!asan_inited)) return;
AsanThread *t = GetCurrentThread(); AsanThread *t = GetCurrentThread();
if (t && !t->isUnwinding() && WillUseFastUnwind(request_fast)) { if (!t || t->isUnwinding()) {
#if SANITIZER_CAN_SLOW_UNWIND
UnwindSlowWithOptionalContext(pc, context, max_depth);
#endif
return;
}
ScopedUnwinding unwind_scope(t);
if (WillUseFastUnwind(request_fast)) {
uptr top = t->stack_top(); uptr top = t->stack_top();
uptr bottom = t->stack_bottom(); uptr bottom = t->stack_bottom();
ScopedUnwinding unwind_scope(t);
if (!SANITIZER_MIPS || IsValidFrame(bp, top, bottom)) { if (!SANITIZER_MIPS || IsValidFrame(bp, top, bottom)) {
UnwindFast(pc, bp, top, bottom, max_depth); UnwindFast(pc, bp, top, bottom, max_depth);
return; return;
} }
} }
#if SANITIZER_CAN_SLOW_UNWIND #if SANITIZER_CAN_SLOW_UNWIND
UnwindSlowWithOptionalContext(pc, context, max_depth); UnwindSlowWithOptionalContext(pc, context, max_depth);
#endif #endif
} }
// ------------------ Interface -------------- {{{1 // ------------------ Interface -------------- {{{1
extern "C" { extern "C" {
SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_INTERFACE_ATTRIBUTE
void __sanitizer_print_stack_trace() { void __sanitizer_print_stack_trace() {
using namespace __asan; using namespace __asan;
PRINT_CURRENT_STACK(); PRINT_CURRENT_STACK();
} }
} // extern "C" } // extern "C"