This is an archive of the discontinued LLVM Phabricator instance.

Differential D58925

gn build: Port r342002
ClosedPublic

Authored by thakis on Mar 4 2019, 2:19 PM.

Details

Reviewers
rnk
Commits
rGa92711404cca: gn build: Port r342002
rL355604: gn build: Port r342002
Summary

I had hoped we could remove the dependency on shell32.lib from lib/Support (there isn't much depending on it), but looks like this will take a while. So for now, port this over.

Diff Detail

Event Timeline

thakis created this revision.Mar 4 2019, 2:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2019, 2:19 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
rnk accepted this revision.Mar 5 2019, 11:44 AM

lgtm

This revision is now accepted and ready to land.Mar 5 2019, 11:44 AM
Closed by commit rL355604: gn build: Port r342002 (authored by nico). · Explain WhyMar 7 2019, 7:44 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: kristina. · View Herald TranscriptMar 7 2019, 7:44 AM

Revision Contents

PathSize
llvm/
utils/
gn/
secondary/
llvm/
lib/
Support/
7 lines

Diff 189204

llvm/utils/gn/secondary/llvm/lib/Support/BUILD.gn

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines sources = [
"VirtualFileSystem.cpp", "VirtualFileSystem.cpp",
"Watchdog.cpp", "Watchdog.cpp",
] ]
libs = [] libs = []
if (current_os == "linux" || current_os == "android") { if (current_os == "linux" || current_os == "android") {
libs += [ "dl" ] libs += [ "dl" ]
} else if (current_os == "win") {
# Delay load shell32.dll if possible to speed up process startup.
libs += [ "delayimp.lib" ]
ldflags = [
"-delayload:ole32.dll",
"-delayload:shell32.dll",
]
} }
} }