Page MenuHomePhabricator

[lldb] [lldbtest] Fix getBuildFlags() not to use libstdc++ on NetBSD
ClosedPublic

Authored by mgorny on Mar 2 2019, 2:49 AM.

Details

Summary

Remove the code forcing -stdlib=libstdc++ on NetBSD in getBuildFlags()
method. NetBSD uses libc++ everywhere else, and using libstdc++ here
causes lang/cpp/dynamic-value to fail to build.

NB: I have no clue what getBuildFlags() is supposed to do, and why it's used in the few tests it's used in, so the change can be entirely wrong. However, tests pass for me with it, and it fixes missing symbols I've had when building with libstdc++.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

mgorny created this revision.Mar 2 2019, 2:49 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: abidh. · View Herald Transcript
labath accepted this revision.Mar 2 2019, 8:12 AM

hmm.. interesting. I had no idea this function even exists. It's existence if unfortunate as it seems to duplicate some of the logic already present in makefiles, but that's not your problem here.

This revision is now accepted and ready to land.Mar 2 2019, 8:12 AM
This revision was automatically updated to reflect the committed changes.