Page MenuHomePhabricator

Add wildcard support to all update_* scripts (PR37500)

Authored by RKSimon on Mar 1 2019, 4:13 AM.



We can already update multiple files in each update call, this extends it to work with wildcards as well in the same way as

Diff Detail


Event Timeline

RKSimon created this revision.Mar 1 2019, 4:13 AM
Herald added a project: Restricted Project. · View Herald Transcript
gbedwell added inline comments.Mar 1 2019, 4:37 AM
429 ↗(On Diff #188876)

typo? test_path*s*

Hm, never noticed this. I guess bash always expanded glob beforehand for me.

As a footnote, i wonder if utils/ bitrot nowadays.
I wasn't successful in using it last year.

RKSimon marked an inline comment as done.Mar 1 2019, 4:49 AM
RKSimon added inline comments.
429 ↗(On Diff #188876)

cheers - I tested llc/opt/analyze variants but hadn't mir as I hit some python3 issues ("bytes-like object is required, not 'str'"") that I hadn't tracked down...

RKSimon updated this revision to Diff 188884.EditedMar 1 2019, 4:58 AM

Fixed mir + tested on python27 (although it still doesn't run on python3 - that needs to be fixed separately).

Dropped the cc change as like Roman said it needs some attention first.

Tested llc/opt/analyze on python3 and python27

Doesn't the shell glob files for you?

Doesn't the shell glob files for you?

Not on windows (which is what I care about) and probably others. Bash usually works, although I've seen problems with subfolder expansion on git bash - haven't tested much else.

any more comments?

MaskRay accepted this revision.Mar 4 2019, 7:12 PM
This revision is now accepted and ready to land.Mar 4 2019, 7:12 PM
This revision was automatically updated to reflect the committed changes.