OpenMP 5.0 says that the callback for the events initial-task-begin and initial-task-end has to be ompt_callback_implicit_task. This patch fixes this.
Details
Details
- Reviewers
protze.joachim hbae - Commits
- rZORG0f58bb09824d: [OMPT] Handling of the events of initial-task-begin and initial-task-end
rG0f58bb09824d: [OMPT] Handling of the events of initial-task-begin and initial-task-end
rOMP361157: [OMPT] Handling of the events of initial-task-begin and initial-task-end
rG48b8a4b5190d: [OMPT] Handling of the events of initial-task-begin and initial-task-end
rL361157: [OMPT] Handling of the events of initial-task-begin and initial-task-end
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
runtime/src/kmp_runtime.cpp | ||
---|---|---|
3992 ↗ | (On Diff #188706) | I am not sure if this call corresponds to the 5.0 spec's description (472:26--29).
|
runtime/test/ompt/callback.h | ||
465 ↗ | (On Diff #188706) | I think this statement should print information about ompt_event_initial_task_begin. |
runtime/test/ompt/misc/interoperability.cpp | ||
---|---|---|
118 ↗ | (On Diff #188706) | Please add // CHECK-NOT: {{^}}[[THREAD_ID_1:[0-9]+]]: ompt_event_initial_task_end: Same for the other worker thread. |
Comment Actions
All concerns should be addressed now.
runtime/test/ompt/callback.h | ||
---|---|---|
465 ↗ | (On Diff #188706) | This had an impact on several test. It is done now. |