This is an archive of the discontinued LLVM Phabricator instance.

[AtomicExpand] Allow libcall expansion for non-zero address spaces
ClosedPublic

Authored by reames on Feb 27 2019, 8:53 PM.

Details

Summary

Question to reviewers: is this a good idea? The particular case which caused me to notice this was an unrelated bug which resulted in a misaligned atomic being lowered (i.e. shouldn't have happened), but it seems consistent to lower to libcalls just as we'd lower to normal instructions. Thoughts?

Diff Detail

Event Timeline

reames created this revision.Feb 27 2019, 8:53 PM
arsenm accepted this revision.Mar 4 2019, 7:56 AM

LGTM

This revision is now accepted and ready to land.Mar 4 2019, 7:56 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2019, 2:59 PM