Page MenuHomePhabricator

AMDGPU: Enable function calls by default
ClosedPublic

Authored by arsenm on Feb 26 2019, 10:45 AM.

Details

Reviewers
msearles
Summary

The inline-calls test is only sort of testing what it's intended.
Ideally we would stop running any form of inliner in the backend
passes, but that's antoher step.

Fixes some crashes on illegal call situations which are unfortunately
still valid IR.

Diff Detail

Event Timeline

arsenm created this revision.Feb 26 2019, 10:45 AM
arsenm planned changes to this revision.Feb 26 2019, 10:51 AM

This actually breaks the option completely

arsenm updated this revision to Diff 188435.Feb 26 2019, 11:50 AM
arsenm edited the summary of this revision. (Show Details)
arsenm updated this revision to Diff 188441.Feb 26 2019, 12:30 PM

Split bug fix to separate patch

msearles accepted this revision.Feb 26 2019, 4:01 PM

LGTM; 1 minor nit (typo in comment); no need to re-review

lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
430

Nit: typo in comment 'ssupported'

This revision is now accepted and ready to land.Feb 26 2019, 4:01 PM
arsenm closed this revision.Feb 27 2019, 7:11 PM

r355051