Page MenuHomePhabricator

[DAGCombine] Add undef shuffle elt support to partitionShuffleOfConcats
ClosedPublic

Authored by RKSimon on Feb 23 2019, 2:31 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

RKSimon created this revision.Feb 23 2019, 2:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2019, 2:31 PM
niravd accepted this revision.Feb 25 2019, 6:53 AM

LGTM.

This revision is now accepted and ready to land.Feb 25 2019, 6:53 AM
This revision was automatically updated to reflect the committed changes.
rudkx added a subscriber: rudkx.Feb 25 2019, 2:59 PM
rudkx added inline comments.
llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
17407

This results in a new build warning:

../lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17407:44: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare]
      if ((SubMask[i] % NumElemsPerConcat) != i)

Would you mind taking a look at fixing that?