Page MenuHomePhabricator

[AArch64][GlobalISel] Refactor selectBuildVector to use MachineIRBuilder. NFC.

Authored by aemerson on Feb 21 2019, 3:11 PM.



This is a preparatory change as I want to use emitScalarToVector() elsewhere, and in general we want to transition to MIRBuilder instead of using BuildMI directly.

Diff Detail


Event Timeline

aemerson created this revision.Feb 21 2019, 3:11 PM
paquette accepted this revision.Feb 22 2019, 10:42 AM

LGTM other than some formatting stuff which doesn't really matter. If clang-format did it, then I have no power to argue against it.

1720–1722 ↗(On Diff #187871)

Did clang-format actually do this?

2097–2100 ↗(On Diff #187871)

Formatting looks odd here? In my experience, clang-format would probably indent the .addWhatevers, but meh who knows

This revision is now accepted and ready to land.Feb 22 2019, 10:42 AM
aemerson marked 2 inline comments as done.Feb 22 2019, 11:15 AM
aemerson added inline comments.
1720–1722 ↗(On Diff #187871)

clang-format works in mysterious ways.

2097–2100 ↗(On Diff #187871)

I'll re-run it to check, but I think it did do that.

This revision was automatically updated to reflect the committed changes.