This is an archive of the discontinued LLVM Phabricator instance.

ELF: Remove dead code. NFCI.
ClosedPublic

Authored by pcc on Feb 20 2019, 7:49 PM.

Reviewers

ruiu
• espindola

Commits

Summary

RelocationBaseSection is not used in -r links, so Config->Relocatable will
always be false.

Herald added a project: Restricted Project. · View Herald Transcript

LGTM

This revision is now accepted and ready to land.Feb 20 2019, 9:23 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lld/

trunk/

ELF/

5 lines

Show First 20 Lines • Show All 1,508 Lines • ▼ Show 20 Lines	if (Reloc.Type == Target->RelativeRel)
++NumRelativeRelocs;		++NumRelativeRelocs;
Relocs.push_back(Reloc);		Relocs.push_back(Reloc);
}		}

void RelocationBaseSection::finalizeContents() {		void RelocationBaseSection::finalizeContents() {
// When linking glibc statically, .rel{,a}.plt contains R_*_IRELATIVE		// When linking glibc statically, .rel{,a}.plt contains R_*_IRELATIVE
// relocations due to IFUNC (e.g. strcpy). sh_link will be set to 0 in that		// relocations due to IFUNC (e.g. strcpy). sh_link will be set to 0 in that
// case.		// case.
InputSection *SymTab = Config->Relocatable ? In.SymTab : In.DynSymTab;		if (In.DynSymTab && In.DynSymTab->getParent())
if (SymTab && SymTab->getParent())		getParent()->Link = In.DynSymTab->getParent()->SectionIndex;
getParent()->Link = SymTab->getParent()->SectionIndex;
else		else
getParent()->Link = 0;		getParent()->Link = 0;

if (In.RelaPlt == this)		if (In.RelaPlt == this)
getParent()->Info = In.GotPlt->getParent()->SectionIndex;		getParent()->Info = In.GotPlt->getParent()->SectionIndex;
if (In.RelaIplt == this)		if (In.RelaIplt == this)
getParent()->Info = In.IgotPlt->getParent()->SectionIndex;		getParent()->Info = In.IgotPlt->getParent()->SectionIndex;
}		}
▲ Show 20 Lines • Show All 1,712 Lines • Show Last 20 Lines