This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj]Test basic command-line handling
ClosedPublic

Authored by jhenderson on Feb 20 2019, 8:56 AM.

Details

Summary

There was no real testing for llvm-readobj/llvm-readelf's behaviour under various bad inputs and command-line switches. This patch adds some testing of this, along with basic testing of --version and --help.

Diff Detail

Repository
rL LLVM

Event Timeline

jhenderson created this revision.Feb 20 2019, 8:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 20 2019, 8:56 AM
MaskRay accepted this revision.Feb 20 2019, 10:36 PM
This revision is now accepted and ready to land.Feb 20 2019, 10:36 PM
grimar added inline comments.Feb 21 2019, 1:54 AM
test/tools/llvm-readobj/basic.test
4

I would suggest adding a short single-line description of each test.

Add comments.

grimar accepted this revision.Feb 21 2019, 2:26 AM

LGTM, thanks!

This revision was automatically updated to reflect the committed changes.