This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj]Test basic command-line handling
ClosedPublic

Authored by jhenderson on Feb 20 2019, 8:56 AM.

Download Raw Diff

Details

Reviewers

grimar
rupprecht
MaskRay

Commits

rG6561a823d26f: [llvm-readobj]Test basic command-line handling
rL354567: [llvm-readobj]Test basic command-line handling

Summary

There was no real testing for llvm-readobj/llvm-readelf's behaviour under various bad inputs and command-line switches. This patch adds some testing of this, along with basic testing of --version and --help.

Diff Detail

Repository: rL LLVM

Event Timeline

jhenderson created this revision.Feb 20 2019, 8:56 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 20 2019, 8:56 AM

MaskRay accepted this revision.Feb 20 2019, 10:36 PM

This revision is now accepted and ready to land.Feb 20 2019, 10:36 PM

grimar added inline comments.Feb 21 2019, 1:54 AM

test/tools/llvm-readobj/basic.test
4	I would suggest adding a short single-line description of each test.

Add comments.

LGTM, thanks!

Closed by commit rL354567: [llvm-readobj]Test basic command-line handling (authored by jhenderson). · Explain WhyFeb 21 2019, 3:00 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

test/

tools/

llvm-readobj/

basic.test

30 lines

Diff 187592

test/tools/llvm-readobj/basic.test

	RUN: not llvm-readobj %t.blah 2>&1 \| FileCheck --check-prefix=ENOENT %s			RUN: not llvm-readobj %t.blah 2>&1 \| FileCheck --check-prefix=ENOENT %s
	ENOENT: {{.*}}.blah: {{[Nn]}}o such file or directory			ENOENT: {{.*}}.blah: {{[Nn]}}o such file or directory

				RUN: touch %t.empty
				grimarUnsubmitted Not Done Reply Inline Actions I would suggest adding a short single-line description of each test. grimar: I would suggest adding a short single-line description of each test.
				RUN: not llvm-readobj %t.empty 2>&1 \| FileCheck --check-prefix=EMPTY %s
				EMPTY: {{.*}}.empty: The file was not recognized as a valid object file

				RUN: rm -f %t.a
				RUN: llvm-ar rc %t.a %t.empty
				RUN: llvm-readobj --all %t.a 2>&1 \| FileCheck --check-prefix=NO-OUTPUT --allow-empty %s
				NO-OUTPUT-NOT: {{.}}

				# Test case where no switches are specified.
				RUN: llvm-readobj %p/Inputs/trivial.obj.elf-x86-64 \| FileCheck --check-prefix=HEADER %s
				RUN: llvm-readelf %p/Inputs/trivial.obj.elf-x86-64 \| FileCheck --check-prefix=NO-OUTPUT --allow-empty %s
				HEADER: File: {{.*}}trivial.obj.elf-x86-64
				HEADER: Format: ELF64-x86-64
				HEADER: Arch: x86_64
				HEADER: AddressSize: 64bit

				RUN: not llvm-readobj --unknown-switch 2>&1 \| FileCheck --check-prefix=UNKNOWN %s
				UNKNOWN: Unknown command line argument '--unknown-switch'

				RUN: llvm-readobj --version \| FileCheck %s --check-prefix=VERSION
				RUN: llvm-readelf --version \| FileCheck %s --check-prefix=VERSION
				VERSION: LLVM version

				RUN: llvm-readobj --help \| FileCheck %s --check-prefixes=HELP,USAGE-OBJ
				RUN: llvm-readelf --help \| FileCheck %s --check-prefixes=HELP,USAGE-ELF
				HELP: OVERVIEW: LLVM Object Reader
				USAGE-OBJ: llvm-readobj{{.*}} [options] <input object files>
				USAGE-ELF: llvm-readelf{{.*}} [options] <input object files>