This matches the behavior of the old pass manager. There are some
targets that don't have target machine at all (e.g. le32, spir) which
whose tests would never run with new pass manager. Similarly, we would
need to disable tests for targets that are disabled.
Details
Details
- Reviewers
chandlerc - Commits
- rZORGbc567980e6dc: [Clang][NewPM] Don't bail out if the target machine is empty
rZORGa24443728251: [Clang][NewPM] Don't bail out if the target machine is empty
rGbc567980e6dc: [Clang][NewPM] Don't bail out if the target machine is empty
rGa24443728251: [Clang][NewPM] Don't bail out if the target machine is empty
rG5f2e10e9c325: [Clang][NewPM] Don't bail out if the target machine is empty
rL360100: [Clang][NewPM] Don't bail out if the target machine is empty
rC360100: [Clang][NewPM] Don't bail out if the target machine is empty
Diff Detail
Diff Detail
- Repository
- rC Clang
Event Timeline
Comment Actions
Maybe update at least some of the tests using these targets to additionally run with the new pass manager explicitly enabled via flag?
clang/lib/CodeGen/BackendUtil.cpp | ||
---|---|---|
950 | I would say RequiresCodeGen instead of UsesCodeGen as we will still *use* the target manager even if it isn't required when emitting a .ll file. |
I would say RequiresCodeGen instead of UsesCodeGen as we will still *use* the target manager even if it isn't required when emitting a .ll file.