Page MenuHomePhabricator

[libcxx] Portability fix: make std::io_base::xalloc() test independent on initial index value.
ClosedPublic

Authored by amakc11 on Feb 15 2019, 12:07 PM.

Details

Summary

The requirement to std::io_base::xalloc() is: "Returns: index++". The requirement to static field index is: "initialized to an unspecified value". This patch removes the dependency of the std::io_base::xalloc() test on specific initial value of this static field implemented in libc++ and makes the test pass on other conformant implementations.

Diff Detail

Repository
rL LLVM

Event Timeline

amakc11 created this revision.Feb 15 2019, 12:07 PM
ldionne accepted this revision.Feb 28 2019, 4:46 PM
This revision is now accepted and ready to land.Feb 28 2019, 4:46 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2019, 4:51 PM