Page MenuHomePhabricator

[Sema] Diagnose floating point conversions based on target semantics
ClosedPublic

Authored by erik.pilkington on Feb 14 2019, 2:43 PM.

Details

Summary

...instead of just comparing rank. Also, fix a bad warning about _Float16, since its declared out of order in BuiltinTypes.def, meaning comparing rank using BuiltinType::getKind() is incorrect.

Came out of some discussion on D58145

Thanks!

Diff Detail

Repository
rC Clang

Event Timeline

rjmccall accepted this revision.Feb 14 2019, 6:42 PM

LGTM, thanks!

This revision is now accepted and ready to land.Feb 14 2019, 6:42 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2019, 5:11 PM