This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Don't compile GetPathAssumingFileIsRelativeToExec on Fuchsia
ClosedPublic

Authored by phosek on Feb 11 2019, 4:06 PM.

Diff Detail

Event Timeline

phosek created this revision.Feb 11 2019, 4:06 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 11 2019, 4:06 PM
Herald added subscribers: llvm-commits, Restricted Project, kubamracek. · View Herald Transcript
vitalybuka added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_suppressions.cc
55

Can you extract this into a function so we have no #if !SANITIZER_FUCHSIA here
and just single if with different definitions of the function?

vitalybuka accepted this revision.Feb 11 2019, 4:17 PM

LGTM either way

This revision is now accepted and ready to land.Feb 11 2019, 4:17 PM
phosek updated this revision to Diff 186372.Feb 11 2019, 5:06 PM
phosek marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.