Page MenuHomePhabricator

[ThinLTO] Record in index whether IR used a flattened sample PGO profile
AbandonedPublic

Authored by tejohnson on Feb 11 2019, 10:19 AM.

Details

Reviewers
wmi
Summary

This will be used to adjust importing threshold defaults, since
flattened profiles are less accurate about hotness.

It required moving the flattened-profile-use flag definition to a
different location that is accessible by the pass managers as well as
from the module summary index.

Diff Detail

Event Timeline

tejohnson created this revision.Feb 11 2019, 10:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2019, 10:19 AM
tejohnson marked an inline comment as done.Feb 11 2019, 10:21 AM
tejohnson added inline comments.
lib/ProfileData/SampleProf.cpp
28

@wmi Would it be possible to record this information in the sample profile file itself? That would be cleaner.

wmi accepted this revision.Feb 11 2019, 1:35 PM

LGTM.

lib/ProfileData/SampleProf.cpp
28

That is a possiblity. But have to consider what is the best way to category the information we want to encode.

This revision is now accepted and ready to land.Feb 11 2019, 1:35 PM
tejohnson abandoned this revision.Feb 14 2019, 6:15 AM

Decided to take a different approach for now.