We must only set the construction vtable visibility after we create the
vtable initializer, otherwise the global value will be treated as
declaration rather than definition and the visibility won't be set.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
lgtm with a comment (and perhaps an assertion).
clang/lib/CodeGen/CGVTables.cpp | ||
---|---|---|
777 ↗ | (On Diff #186141) | Give it a comment pointing out the importance of doing this after createVTableInitializer rather than before. |