Page MenuHomePhabricator

Small refactoring of FileError. NFC

Authored by evgeny777 on Feb 8 2019, 5:32 AM.

Event Timeline

evgeny777 created this revision.Feb 8 2019, 5:32 AM
jhenderson accepted this revision.Feb 8 2019, 5:44 AM

LGTM, with the comment fix.

1218–1219 ↗(On Diff #185952)

I'd rephrase this slightly to say "Concatenate a source file path and/or name with a std::error_code to form an Error object", and then delete the second sentence.

This revision is now accepted and ready to land.Feb 8 2019, 5:44 AM
rupprecht added inline comments.Feb 8 2019, 10:11 AM
1221 ↗(On Diff #185952)

errorCodeToError(EC) seems more appropriate, given there is no string

1224 ↗(On Diff #185952)

Update this too

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2019, 1:49 AM
Herald added a subscriber: kristina. · View Herald Transcript