Page MenuHomePhabricator
Differential D57810

MC/ELF: Allow targets to set ABI version
ClosedPublic
Actions

Authored by kzhuravl on Feb 6 2019, 1:19 AM.

Details

Reviewers
pcc
t-tye
ruiu
Commits
rGe0484eb2f2d0: MC/ELF: Allow targets to set ABI version
rL354072: MC/ELF: Allow targets to set ABI version

Diff Detail

Repository
rL LLVM

Event Timeline

kzhuravl created this revision.Feb 6 2019, 1:19 AM
Herald added a subscriber: wdng. · View Herald TranscriptFeb 6 2019, 1:19 AM
kzhuravl added a child revision: D57811: AMDGPU: Set ABI version to 1 for code object v3.Feb 6 2019, 1:20 AM
JohnReagan added a subscriber: JohnReagan.Feb 6 2019, 5:59 AM

Awesome. I have a out-of-tree change similar to this but I won't be rebasing for another 6 months or so. You've saved me the work. :)

kzhuravl added a reviewer: ruiu.Feb 11 2019, 12:21 AM
kzhuravl added a comment.Feb 12 2019, 4:45 PM

ping

ruiu accepted this revision.Feb 13 2019, 2:27 PM

LGTM

This revision is now accepted and ready to land.Feb 13 2019, 2:27 PM
Closed by commit rL354072: MC/ELF: Allow targets to set ABI version (authored by kzhuravl). · Explain WhyFeb 14 2019, 2:43 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2019, 2:43 PM

Revision Contents
Changeset List

PathSize
llvm/
trunk/
include/
llvm/
MC/
4 lines
lib/
MC/
3 lines
5 lines

Diff 186921

View Options

llvm/trunk/include/llvm/MC/MCELFObjectWriter.h

Loading...
View Options

llvm/trunk/lib/MC/ELFObjectWriter.cpp

Loading...
View Options

llvm/trunk/lib/MC/MCELFObjectTargetWriter.cpp

Loading...