In order to support big endian targets for the BuildPairF64 nodes we
just need to swap the low/high pair registers. Additionally, for the
ExtractElementF64 nodes we have to calculate the correct stack offset
with respect to the node's register/operand that we want to extract.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Please, note that with these changes, the prefixes 32R2-FP64A-BE & 32R2-FP64A-LE in the file test/CodeGen/Mips/fp64a.ll
expect the same output. If the changes are fine, I will merge them under a new single check prefix in another review request.
Comment Actions
LGTM with 32R2-FP64A-LE and 32R2-FP64A-BE merged together.
test/CodeGen/Mips/fp64a.ll | ||
---|---|---|
40–44 | Please merge 32R2-FP64A-LE and 32R2-FP64A-BE together now that they are the same. |
Comment Actions
Merged the 32R2-FP64A-LE and 32R2-FP64A-BE check prefixes under a new common
prefix called 32R2-FP64A.
Comment Actions
Send correct update that includes the original review's changes.
Merged the 32R2-FP64A-LE and 32R2-FP64A-BE check prefixes under a new common
prefix called 32R2-FP64A.
Please merge 32R2-FP64A-LE and 32R2-FP64A-BE together now that they are the same.