This is an archive of the discontinued LLVM Phabricator instance.

X86AsmParser: Do not process a non-existent token
ClosedPublic

Authored by BrandonTJones on Jan 29 2019, 3:39 AM.

Reviewers

Commits

Summary

This error can only happen if an unfinished operation is at Eof.

ping

ping

Can you write a test case?

added test case

LGTM

This revision is now accepted and ready to land.Mar 21 2019, 10:56 PM

I do not have permissions to commit, can you do it for me? Thanks.

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Target/

X86/

AsmParser/

5 lines

Show First 20 Lines • Show All 2,975 Lines • ▼ Show 20 Lines	bool X86AsmParser::MatchAndEmitATTInstruction(SMLoc IDLoc, unsigned &Opcode,
case Match_MissingFeature:		case Match_MissingFeature:
return ErrorMissingFeature(IDLoc, ErrorInfo, MatchingInlineAsm);		return ErrorMissingFeature(IDLoc, ErrorInfo, MatchingInlineAsm);
case Match_InvalidOperand:		case Match_InvalidOperand:
WasOriginallyInvalidOperand = true;		WasOriginallyInvalidOperand = true;
break;		break;
case Match_MnemonicFail:		case Match_MnemonicFail:
break;		break;
}		}
		if (Op.getToken().empty()) {
		Error(IDLoc, "instruction must have size higher than 0", EmptyRange,
		MatchingInlineAsm);
		return true;
		}

// FIXME: Ideally, we would only attempt suffix matches for things which are		// FIXME: Ideally, we would only attempt suffix matches for things which are
// valid prefixes, and we could just infer the right unambiguous		// valid prefixes, and we could just infer the right unambiguous
// type. However, that requires substantially more matcher support than the		// type. However, that requires substantially more matcher support than the
// following hack.		// following hack.

// Change the operand to point to a temporary token.		// Change the operand to point to a temporary token.
StringRef Base = Op.getToken();		StringRef Base = Op.getToken();
▲ Show 20 Lines • Show All 497 Lines • Show Last 20 Lines