This is an archive of the discontinued LLVM Phabricator instance.

Differential D57258

Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF
ClosedPublic

Authored by thakis on Jan 25 2019, 1:12 PM.

Details

Reviewers
rnk
zturner
Commits
rGe9cac31dac90: Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF
rL352253: Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF
rC352253: Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF
Summary

libclang can be built in shared or static mode. On Windows, with LLVM_ENABLE_PIC=OFF, it was built in neither mode, leading to clients of libclang (c-index-test, c-arcmt-test) failing to link with it set.

Since PIC isn't really a thing on Windows, build libclang in shared mode when LLVM_ENABLE_PIC=OFF on Windows. This is also somewhat symmetric with the existing ENABLE_STATIC a few lines down.

Diff Detail

Event Timeline

thakis created this revision.Jan 25 2019, 1:12 PM
Herald added a subscriber: mgorny. · View Herald TranscriptJan 25 2019, 1:12 PM
zturner accepted this revision.Jan 25 2019, 1:35 PM
This revision is now accepted and ready to land.Jan 25 2019, 1:35 PM
Closed by commit rC352253: Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF (authored by nico). · Explain WhyJan 25 2019, 3:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
libclang/
2 lines

Diff 183606

tools/libclang/CMakeLists.txt

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines
if(MSVC) if(MSVC)
# Avoid LNK4197 by not specifying libclang.exports here. # Avoid LNK4197 by not specifying libclang.exports here.
# Each functions is exported as "dllexport" in include/clang-c. # Each functions is exported as "dllexport" in include/clang-c.
# KB835326 # KB835326
set(LLVM_EXPORTED_SYMBOL_FILE) set(LLVM_EXPORTED_SYMBOL_FILE)
endif() endif()
if( LLVM_ENABLE_PIC ) if(LLVM_ENABLE_PIC OR WIN32)
set(ENABLE_SHARED SHARED) set(ENABLE_SHARED SHARED)
endif() endif()
if((NOT LLVM_ENABLE_PIC OR LIBCLANG_BUILD_STATIC) AND NOT WIN32) if((NOT LLVM_ENABLE_PIC OR LIBCLANG_BUILD_STATIC) AND NOT WIN32)
set(ENABLE_STATIC STATIC) set(ENABLE_STATIC STATIC)
endif() endif()
if(WIN32) if(WIN32)
▲ Show 20 Lines • Show All 88 Lines • Show Last 20 Lines