rdar://problem/46886288
Details
Diff Detail
- Build Status
Buildable 27287 Build 27286: arc lint + arc unit
Event Timeline
lldb/source/Utility/Scalar.cpp | ||
---|---|---|
161 | I'm confused. You say it returns a pointer to an array of four uint64_t values, but here you're clearly swapping the order of eight uint64_t values. Is the comment wrong? Anyway, how about: std::swap(apint_words[0], apint_words[7]); std::swap(apint_words[1], apint_words[6]); std::swap(apint_words[2], apint_words[5]); std::swap(apint_words[3], apint_words[4]); |
lldb/source/Utility/Scalar.cpp | ||
---|---|---|
161 | Yes the comment is wrong. I need to update it. |
lldb/source/Utility/Scalar.cpp | ||
---|---|---|
168 | I updated the comment but I can't really easily use std::swap or std::reverse because they operate on vectors and the unit of currency here is an array. |
lldb/source/Utility/Scalar.cpp | ||
---|---|---|
168 | I'm confused why std::swap(swapped_words[7], swapped_words[0]); and similar for the other 4 doesn't work though. |
lldb/source/Utility/Scalar.cpp | ||
---|---|---|
168 | /Users/davide/llvm-monorepo/llvm-mono/llvm/tools/lldb/source/Utility/Scalar.cpp:144:7: error: no matching function for call to 'swap' std::swap(apint_words[0], apint_words[3]); ^~~~~~~~~ /Applications/Xcode4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/type_traits:4515:1: note: candidate template ignored: requirement 'is_move_assignable<const unsigned long long>::value' was not satisfied [with _Tp = const unsigned long long] swap(_Tp& __x, _Tp& __y) _NOEXCEPT_(is_nothrow_move_constructible<_Tp>::value && |
I'm curious, everything else in this patch refers to 512, how does this fit in?