Page MenuHomePhabricator

Add information about unit tests to the testing guide
ClosedPublic

Authored by michaelplatings on Jan 23 2019, 1:31 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

carwil added a subscriber: carwil.EditedJan 23 2019, 3:33 AM

Thanks for posting this! Always good to see doc updates.
Bit of _very_ opinionated bike-shedding. Content otherwise LGTM!

docs/TestingGuide.rst
101 ↗(On Diff #183060)

This is incredibly picky, but I'd prefer an 'and' here.

104 ↗(On Diff #183060)

ditto.

110 ↗(On Diff #183060)

ditto (perhaps with a capital R, as well).

Addressed @carwil's comments

michaelplatings marked 3 inline comments as done.Jan 23 2019, 3:54 AM
carwil accepted this revision.Jan 24 2019, 6:52 AM

Thanks for the changes! LGTM. Approved.

This revision is now accepted and ready to land.Jan 24 2019, 6:52 AM
This revision was automatically updated to reflect the committed changes.