This is an archive of the discontinued LLVM Phabricator instance.

Fix compiler-rt build on FreeBSD 10.1
ClosedPublic

Authored by emaste on Oct 9 2014, 7:57 AM.

Details

Summary

We have to #define _WANT_RTENTRY to get struct rtentry, and add headers that it depends on.

Diff Detail

Event Timeline

emaste updated this revision to Diff 14653.Oct 9 2014, 7:57 AM
emaste retitled this revision from to Fix compiler-rt build on FreeBSD 10.1.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a subscriber: Unknown Object (MLST).
emaste updated this revision to Diff 14654.Oct 9 2014, 8:12 AM

SIOCADDRT and SIOCDELRT also do not exist in FreeBSD 10.1

commit 8293a6c1cc71ff884e6fb58936226f3c0bd21488
Author: glebius <glebius@FreeBSD.org>
Date:   Sat Mar 15 06:49:32 2014 +0000

    Garbage collect long time obsoleted (or never used) stuff from routing API.

Notes:
    svn path=/head/; revision=263203
samsonov added subscribers: eugenis, samsonov.

Adding eugenis just in case. The change looks fine to me.

lib/sanitizer_common/sanitizer_platform_limits_posix.cc
17

Could you move this below

#if SANITIZER_LINUX || SANITIZER_FREEBSD || SANITIZER_MAC

line?

samsonov accepted this revision.Oct 9 2014, 6:17 PM
samsonov added a reviewer: samsonov.
This revision is now accepted and ready to land.Oct 9 2014, 6:17 PM
emaste added inline comments.Oct 9 2014, 7:43 PM
lib/sanitizer_common/sanitizer_platform_limits_posix.cc
17

Nest it inside the block at line 23? Sure.

eugenis accepted this revision.Oct 10 2014, 1:49 AM
eugenis edited edge metadata.

LGTM

emaste closed this revision.Oct 14 2014, 2:19 PM
emaste updated this revision to Diff 14890.

Closed by commit rL219722 (authored by @emaste).