This is an archive of the discontinued LLVM Phabricator instance.

Fix compiler-rt build on FreeBSD 10.1
ClosedPublic

Authored by emaste on Oct 9 2014, 7:57 AM.

Download Raw Diff

Details

Reviewers

samsonov
eugenis

Commits

rG3ba162d2f9e9: Fix compiler-rt build on FreeBSD 10.1
rCRT219722: Fix compiler-rt build on FreeBSD 10.1
rL219722: Fix compiler-rt build on FreeBSD 10.1

Summary

We have to #define _WANT_RTENTRY to get struct rtentry, and add headers that it depends on.

Diff Detail

Event Timeline

emaste updated this revision to Diff 14653.Oct 9 2014, 7:57 AM

emaste retitled this revision from to Fix compiler-rt build on FreeBSD 10.1.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a subscriber: Unknown Object (MLST).

SIOCADDRT and SIOCDELRT also do not exist in FreeBSD 10.1

commit 8293a6c1cc71ff884e6fb58936226f3c0bd21488
Author: glebius <glebius@FreeBSD.org>
Date:   Sat Mar 15 06:49:32 2014 +0000

    Garbage collect long time obsoleted (or never used) stuff from routing API.

Notes:
    svn path=/head/; revision=263203

Adding eugenis just in case. The change looks fine to me.

lib/sanitizer_common/sanitizer_platform_limits_posix.cc
17	Could you move this below #if SANITIZER_LINUX \|\| SANITIZER_FREEBSD \|\| SANITIZER_MAC line?

samsonov accepted this revision.Oct 9 2014, 6:17 PM

samsonov added a reviewer: samsonov.

This revision is now accepted and ready to land.Oct 9 2014, 6:17 PM

emaste added inline comments.Oct 9 2014, 7:43 PM

lib/sanitizer_common/sanitizer_platform_limits_posix.cc
17	Nest it inside the block at line 23? Sure.

LGTM

Closed by commit rL219722 (authored by @emaste).

Revision Contents

Path

Size

lib/

sanitizer_common/

sanitizer_platform_limits_posix.cc

6 lines

Diff 14653

lib/sanitizer_common/sanitizer_platform_limits_posix.cc

	//===-- sanitizer_platform_limits_posix.cc --------------------------------===//			//===-- sanitizer_platform_limits_posix.cc --------------------------------===//
	//			//
	// The LLVM Compiler Infrastructure			// The LLVM Compiler Infrastructure
	//			//
	// This file is distributed under the University of Illinois Open Source			// This file is distributed under the University of Illinois Open Source
	// License. See LICENSE.TXT for details.			// License. See LICENSE.TXT for details.
	//			//
	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//
	//			//
	// This file is a part of Sanitizer common code.			// This file is a part of Sanitizer common code.
	//			//
	// Sizes and layouts of platform-specific POSIX data structures.			// Sizes and layouts of platform-specific POSIX data structures.
	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//


	#include "sanitizer_platform.h"			#include "sanitizer_platform.h"
				#if SANITIZER_FREEBSD
				samsonovUnsubmitted Not Done Reply Inline Actions Could you move this below #if SANITIZER_LINUX \|\| SANITIZER_FREEBSD \|\| SANITIZER_MAC line? samsonov: Could you move this below #if SANITIZER_LINUX \|\| SANITIZER_FREEBSD \|\| SANITIZER_MAC line?
				emasteAuthorUnsubmitted Not Done Reply Inline Actions Nest it inside the block at line 23? Sure. emaste: Nest it inside the block at line 23? Sure.
				#define _WANT_RTENTRY
				#include <sys/param.h>
				#include <sys/socketvar.h>
				#endif

	#if SANITIZER_LINUX \|\| SANITIZER_FREEBSD \|\| SANITIZER_MAC			#if SANITIZER_LINUX \|\| SANITIZER_FREEBSD \|\| SANITIZER_MAC

	#include <arpa/inet.h>			#include <arpa/inet.h>
	#include <dirent.h>			#include <dirent.h>
	#include <errno.h>			#include <errno.h>
	#include <grp.h>			#include <grp.h>
	#include <limits.h>			#include <limits.h>
	#include <net/if.h>			#include <net/if.h>
	▲ Show 20 Lines • Show All 1,153 Lines • Show Last 20 Lines