This is an archive of the discontinued LLVM Phabricator instance.

[LLD] [docs] Amend the release notes with more things I've contributed since the last release
ClosedPublic

Authored by mstorsjo on Jan 21 2019, 1:42 AM.

Download Raw Diff

Details

Reviewers

ruiu
rnk
hans

Commits

rGa05d35f16368: [docs] Amend the release notes with more things I've contributed since the last…
rL351868: [docs] Amend the release notes with more things I've contributed since the last…

Summary

I earlier wrote the most of the relnotes for things I've contributed this cycle, but I found a few more notable things while looking through the changelog.

Diff Detail

Event Timeline

mstorsjo created this revision.Jan 21 2019, 1:42 AM

lgtm

This revision is now accepted and ready to land.Jan 22 2019, 10:37 AM

ruiu added inline comments.Jan 22 2019, 10:39 AM

docs/ReleaseNotes.rst
73	I don't know if I get the meaning of this sentence correctly. The option is accepted and ignored, /therefore/ no build id was generated?

mstorsjo marked an inline comment as done.Jan 22 2019, 10:45 AM

mstorsjo added inline comments.

docs/ReleaseNotes.rst
73	Well, we still ignore it in the mingw frontend and generate the buildid in COFF/Writer.cpp regardless if the flag was set.

ruiu added inline comments.Jan 22 2019, 10:53 AM

docs/ReleaseNotes.rst
73	How about something like this? Previously, the build-id option did not actually generate a build id unless --pdb was specified.

mstorsjo marked an inline comment as done.Jan 22 2019, 10:59 AM

mstorsjo added inline comments.

docs/ReleaseNotes.rst
73	That sounds good, thanks!

LGTM

I can submit this for you if you don't know how to do this to the 8.0 branch.

In D57005#1366666, @ruiu wrote:

LGTM

I can submit this for you if you don't know how to do this to the 8.0 branch.

Thanks, but I think I know how to get it committed on the branch!

Closed by commit rL351868: [docs] Amend the release notes with more things I've contributed since the last… (authored by mstorsjo). · Explain WhyJan 22 2019, 12:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

docs/

ReleaseNotes.rst

7 lines

Diff 182755

docs/ReleaseNotes.rst

	Show First 20 Lines • Show All 60 Lines • ▼ Show 20 Lines
	* lld can now use existing normal MinGW sysroots with import libraries and			* lld can now use existing normal MinGW sysroots with import libraries and
	CRT startup object files for GNU binutils. lld can handle most object			CRT startup object files for GNU binutils. lld can handle most object
	files produced by GCC, and thus works as a drop-in replacement for			files produced by GCC, and thus works as a drop-in replacement for
	ld.bfd in such environments. (There are known issues with linking crtend.o			ld.bfd in such environments. (There are known issues with linking crtend.o
	from GCC in setups with DWARF exceptions though, where object files are			from GCC in setups with DWARF exceptions though, where object files are
	linked in a different order than with GNU ld, inserting a DWARF exception			linked in a different order than with GNU ld, inserting a DWARF exception
	table terminator too early.)			table terminator too early.)

				* lld now supports COFF embedded directives for linking to nondefault
				libraries, just like for the normal COFF target.

				* Actually generate a codeview build id signature, even if not creating a PDB.
				Previously, the ``--build-id`` option was accepted and ignored, but no
				ruiuUnsubmitted Not Done Reply Inline Actions I don't know if I get the meaning of this sentence correctly. The option is accepted and ignored, /therefore/ no build id was generated? ruiu: I don't know if I get the meaning of this sentence correctly. The option is accepted and…
				mstorsjoAuthorUnsubmitted Done Reply Inline Actions Well, we still ignore it in the mingw frontend and generate the buildid in COFF/Writer.cpp regardless if the flag was set. mstorsjo: Well, we still ignore it in the mingw frontend and generate the buildid in COFF/Writer.cpp…
				ruiuUnsubmitted Not Done Reply Inline Actions How about something like this? Previously, the build-id option did not actually generate a build id unless --pdb was specified. ruiu: How about something like this? Previously, the build-id option did not actually generate a…
				mstorsjoAuthorUnsubmitted Done Reply Inline Actions That sounds good, thanks! mstorsjo: That sounds good, thanks!
				build id was generated.

	MachO Improvements			MachO Improvements
	------------------			------------------

	* Item 1.			* Item 1.

	WebAssembly Improvements			WebAssembly Improvements
	------------------------			------------------------

	* Add initial support for creating shared libraries (-shared).			* Add initial support for creating shared libraries (-shared).
	Note: The shared library format is still under active development and may			Note: The shared library format is still under active development and may
	undergo significant changes in future versions.			undergo significant changes in future versions.
	See: https://github.com/WebAssembly/tool-conventions/blob/master/DynamicLinking.md			See: https://github.com/WebAssembly/tool-conventions/blob/master/DynamicLinking.md