This is an archive of the discontinued LLVM Phabricator instance.

Differential D56832

GlobalISel: Verify G_ICMP/G_FCMP vector types
ClosedPublic

Authored by arsenm on Jan 17 2019, 1:59 AM.

Details

Reviewers
aemerson
aditya_nandakumar

Diff Detail

Event Timeline

arsenm created this revision.Jan 17 2019, 1:59 AM
Herald added subscribers: kristof.beyls, rovka, wdng. · View Herald TranscriptJan 17 2019, 1:59 AM
aditya_nandakumar accepted this revision.Jan 18 2019, 7:51 AM
This revision is now accepted and ready to land.Jan 18 2019, 7:51 AM
Herald added a subscriber: volkan. · View Herald TranscriptJan 18 2019, 7:51 AM
arsenm closed this revision.Jan 18 2019, 12:53 PM

r351591

Revision Contents

PathSize
lib/
CodeGen/
11 lines
test/
Verifier/
40 lines
40 lines

Diff 182224

lib/CodeGen/MachineVerifier.cpp

Show First 20 Lines • Show All 1,191 Lines • ▼ Show 20 Lines if (SrcTy.isValid() || DstTy.isValid()) {
if (!DstOp.getSubReg() && !SrcOp.getSubReg()) { if (!DstOp.getSubReg() && !SrcOp.getSubReg()) {
report("Copy Instruction is illegal with mismatching sizes", MI); report("Copy Instruction is illegal with mismatching sizes", MI);
errs() << "Def Size = " << DstSize << ", Src Size = " << SrcSize errs() << "Def Size = " << DstSize << ", Src Size = " << SrcSize
<< "\n"; << "\n";
} }
} }
break; break;
} }
case TargetOpcode::G_ICMP:
case TargetOpcode::G_FCMP: {
LLT DstTy = MRI->getType(MI->getOperand(0).getReg());
LLT SrcTy = MRI->getType(MI->getOperand(2).getReg());
if ((DstTy.isVector() != SrcTy.isVector()) ||
(DstTy.isVector() && DstTy.getNumElements() != SrcTy.getNumElements()))
report("Generic vector icmp/fcmp must preserve number of lanes", MI);
break;
}
case TargetOpcode::STATEPOINT: case TargetOpcode::STATEPOINT:
if (!MI->getOperand(StatepointOpers::IDPos).isImm() || if (!MI->getOperand(StatepointOpers::IDPos).isImm() ||
!MI->getOperand(StatepointOpers::NBytesPos).isImm() || !MI->getOperand(StatepointOpers::NBytesPos).isImm() ||
!MI->getOperand(StatepointOpers::NCallArgsPos).isImm()) !MI->getOperand(StatepointOpers::NCallArgsPos).isImm())
report("meta operands to STATEPOINT not constant!", MI); report("meta operands to STATEPOINT not constant!", MI);
break; break;
auto VerifyStackMapConstant = [&](unsigned Offset) { auto VerifyStackMapConstant = [&](unsigned Offset) {
▲ Show 20 Lines • Show All 1,265 Lines • Show Last 20 Lines

test/Verifier/test_g_fcmp.mir

  • This file was added.
#RUN: not llc -o - -global-isel -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
# REQUIRES: global-isel, aarch64-registered-target
---
name: test_fcmp
legalized: true
regBankSelected: false
selected: false
tracksRegLiveness: true
liveins:
body: |
bb.0:
%0:_(s32) = G_FCONSTANT float 0.0
%1:_(s32) = G_FCONSTANT float 1.0
; Vector result, scalar source
; CHECK: Bad machine code: Generic vector icmp/fcmp must preserve number of lanes
%2:_(<2 x s1>) = G_FCMP floatpred(oeq), %0, %1
; Scalar result, vector source
; CHECK: Bad machine code: Generic vector icmp/fcmp must preserve number of lanes
%3:_(<2 x s32>) = G_IMPLICIT_DEF
%4:_(<2 x s32>) = G_IMPLICIT_DEF
%5:_(s1) = G_FCMP floatpred(oeq), %3, %4
; mismatched element count
; CHECK: Bad machine code: Generic vector icmp/fcmp must preserve number of
%6:_(<2 x s32>) = G_IMPLICIT_DEF
%7:_(<2 x s32>) = G_IMPLICIT_DEF
%8:_(<4 x s1>) = G_FCMP floatpred(oeq), %6, %7
; mismatched scalar element type
; CHECK: *** Bad machine code: Type mismatch in generic instruction ***
%9:_(s32) = G_FCONSTANT float 0.0
%10:_(s64) = G_FCONSTANT float 1.0
%11:_(s1) = G_FCMP floatpred(oeq), %9, %10
...

test/Verifier/test_g_icmp.mir

  • This file was added.
#RUN: not llc -o - -global-isel -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
# REQUIRES: global-isel, aarch64-registered-target
---
name: test_icmp
legalized: true
regBankSelected: false
selected: false
tracksRegLiveness: true
liveins:
body: |
bb.0:
%0:_(s32) = G_CONSTANT i32 0
%1:_(s32) = G_CONSTANT i32 1
; Vector result, scalar source
; CHECK: Bad machine code: Generic vector icmp/fcmp must preserve number of lanes
%2:_(<2 x s1>) = G_ICMP intpred(eq), %0, %1
; Scalar result, vector source
; CHECK: Bad machine code: Generic vector icmp/fcmp must preserve number of lanes
%3:_(<2 x s32>) = G_IMPLICIT_DEF
%4:_(<2 x s32>) = G_IMPLICIT_DEF
%5:_(s1) = G_ICMP intpred(eq), %3, %4
; mismatched element count
; CHECK: Bad machine code: Generic vector icmp/fcmp must preserve number of
%6:_(<2 x s32>) = G_IMPLICIT_DEF
%7:_(<2 x s32>) = G_IMPLICIT_DEF
%8:_(<4 x s1>) = G_ICMP intpred(eq), %6, %7
; mismatched scalar element type
; CHECK: *** Bad machine code: Type mismatch in generic instruction ***
%9:_(s32) = G_CONSTANT i32 0
%10:_(s64) = G_CONSTANT i32 1
%11:_(s1) = G_ICMP intpred(eq), %9, %10
...