This is an archive of the discontinued LLVM Phabricator instance.

Differential D56808

[llvm-readobj] Fix hexdump test
AbandonedPublic

Authored by tamur on Jan 16 2019, 1:53 PM.

Details

Reviewers
sidneym
Summary

Currently it uses a path like %p/../.. which does not work in some setups (e.g. with symbolic links and etc).

Diff Detail

Event Timeline

tamur created this revision.Jan 16 2019, 1:53 PM
Herald added subscribers: llvm-commits, rupprecht. · View Herald TranscriptJan 16 2019, 1:53 PM
Harbormaster completed remote builds in B26936: Diff 182139.Jan 16 2019, 1:53 PM
rupprecht added a comment.Jan 16 2019, 2:12 PM

test/tools/llvm-readobj/program-headers.test is doing the same thing, so you should look at that one too.

Please prefix the commit description with [llvm-readobj]

test/tools/llvm-readobj/hexdump.test
2

Use test/tools/llvm-readobj/Inputs/phdrs-elf.exe-x86_64 so that the start will be non-zero, which is what the original patch was fixing.

5

{{^}}0x00400610

tamur retitled this revision from Fix hexdump test to [llvm-readobj] Fix hexdump test.Jan 16 2019, 2:15 PM
tamur updated this revision to Diff 182153.Jan 16 2019, 2:37 PM
Harbormaster completed remote builds in B26940: Diff 182153.Jan 16 2019, 2:37 PM
tamur marked 2 inline comments as done.Jan 16 2019, 2:37 PM
sidneym accepted this revision.Jan 16 2019, 4:06 PM
This revision is now accepted and ready to land.Jan 16 2019, 4:06 PM
tamur abandoned this revision.Jan 16 2019, 4:39 PM

I found a workaround, cancelling the patch.

Revision Contents

PathSize
test/
tools/
llvm-readobj/
4 lines

Diff 182153

test/tools/llvm-readobj/hexdump.test

// Check dumping of the hexadecimal bytes of a section. // Check dumping of the hexadecimal bytes of a section.
RUN: llvm-readobj -x .text %p/../../Object/Inputs/hello-world.elf-x86-64 | FileCheck %s RUN: llvm-readobj -x .text %p/Inputs/phdrs-elf.exe-x86_64 | FileCheck %s
rupprechtUnsubmitted
Done
ReplyInline Actions

Use test/tools/llvm-readobj/Inputs/phdrs-elf.exe-x86_64 so that the start will be non-zero, which is what the original patch was fixing.

rupprecht: Use test/tools/llvm-readobj/Inputs/phdrs-elf.exe-x86_64 so that the start will be non-zero…
CHECK: Hex dump of section '.text': CHECK: Hex dump of section '.text':
CHECK-NEXT: {{^}}0x00400460 CHECK-NEXT: {{^}}0x00400610
rupprechtUnsubmitted
Done
ReplyInline Actions

{{^}}0x00400610

rupprecht: {{^}}0x00400610