Page MenuHomePhabricator

[llvm-readobj] Fix hexdump test
AbandonedPublic

Authored by tamur on Jan 16 2019, 1:53 PM.

Details

Reviewers
sidneym
Summary

Currently it uses a path like %p/../.. which does not work in some setups (e.g. with symbolic links and etc).

Diff Detail

Event Timeline

tamur created this revision.Jan 16 2019, 1:53 PM

test/tools/llvm-readobj/program-headers.test is doing the same thing, so you should look at that one too.

Please prefix the commit description with [llvm-readobj]

test/tools/llvm-readobj/hexdump.test
2

Use test/tools/llvm-readobj/Inputs/phdrs-elf.exe-x86_64 so that the start will be non-zero, which is what the original patch was fixing.

5

{{^}}0x00400610

tamur retitled this revision from Fix hexdump test to [llvm-readobj] Fix hexdump test.Jan 16 2019, 2:15 PM
tamur updated this revision to Diff 182153.Jan 16 2019, 2:37 PM
tamur marked 2 inline comments as done.Jan 16 2019, 2:37 PM
sidneym accepted this revision.Jan 16 2019, 4:06 PM
This revision is now accepted and ready to land.Jan 16 2019, 4:06 PM
tamur abandoned this revision.Jan 16 2019, 4:39 PM

I found a workaround, cancelling the patch.