This is an archive of the discontinued LLVM Phabricator instance.

Differential D56787

[MSP430] Set UseIntegratedAssembler
ClosedPublic

Authored by krisb on Jan 16 2019, 8:15 AM.

Details

Reviewers
asl
Commits
rGb26134bf9213: Enable integrated assembler on MSP430 by default.
rL353192: Enable integrated assembler on MSP430 by default.

Diff Detail

Event Timeline

krisb created this revision.Jan 16 2019, 8:15 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 16 2019, 8:15 AM
Harbormaster completed remote builds in B26914: Diff 182058.Jan 16 2019, 8:15 AM
asl requested changes to this revision.Jan 25 2019, 1:16 AM

This breaks CodeGen/MSP430/mult-alt-generic-msp430.ll :)

This revision now requires changes to proceed.Jan 25 2019, 1:16 AM
krisb added a comment.Jan 25 2019, 6:51 AM

@asl thanks for catching this! Looks like I forgot to amend a fix for the test after testing :( sorry for that.

krisb updated this revision to Diff 183534.Jan 25 2019, 6:52 AM

Fixed broken test.

Harbormaster completed remote builds in B27309: Diff 183534.Jan 25 2019, 6:52 AM
asl accepted this revision.Feb 5 2019, 9:59 AM

LGTM now

This revision is now accepted and ready to land.Feb 5 2019, 9:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2019, 9:59 AM
Closed by commit rL353192: Enable integrated assembler on MSP430 by default. (authored by asl). · Explain WhyFeb 5 2019, 10:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
MSP430/
MCTargetDesc/
1 line
test/
CodeGen/
MSP430/
2 lines

Diff 183534

lib/Target/MSP430/MCTargetDesc/MSP430MCAsmInfo.cpp

Show All 17 Lines
MSP430MCAsmInfo::MSP430MCAsmInfo(const Triple &TT) { MSP430MCAsmInfo::MSP430MCAsmInfo(const Triple &TT) {
CodePointerSize = CalleeSaveStackSlotSize = 2; CodePointerSize = CalleeSaveStackSlotSize = 2;
CommentString = ";"; CommentString = ";";
SeparatorString = "{"; SeparatorString = "{";
AlignmentIsInBytes = false; AlignmentIsInBytes = false;
UsesELFSectionDirectiveForBSS = true; UsesELFSectionDirectiveForBSS = true;
UseIntegratedAssembler = true;
} }

test/CodeGen/MSP430/mult-alt-generic-msp430.ll

; RUN: llc < %s -march=msp430 ; RUN: llc < %s -march=msp430 -no-integrated-as
; ModuleID = 'mult-alt-generic.c' ; ModuleID = 'mult-alt-generic.c'
target datalayout = "e-p:16:16:16-i8:8:8-i16:16:16-i32:16:32-n8:16" target datalayout = "e-p:16:16:16-i8:8:8-i16:16:16-i32:16:32-n8:16"
target triple = "msp430" target triple = "msp430"
@mout0 = common global i16 0, align 2 @mout0 = common global i16 0, align 2
@min1 = common global i16 0, align 2 @min1 = common global i16 0, align 2
@marray = common global [2 x i16] zeroinitializer, align 2 @marray = common global [2 x i16] zeroinitializer, align 2
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines