This is an archive of the discontinued LLVM Phabricator instance.

Differential D56785

[MSP430] Fix absolute addressing mode printing in AsmPrinter
ClosedPublic

Authored by krisb on Jan 16 2019, 7:47 AM.

Details

Reviewers
asl
Commits
rG509d5c4a7dcc: [MSP430] Fix absolute addressing mode printing in AsmPrinter
rL352178: [MSP430] Fix absolute addressing mode printing in AsmPrinter
Summary

Align checks for absolute addressing mode with its current
implementation (SR is used as a base register).

It fixes https://bugs.llvm.org/show_bug.cgi?id=39993

Diff Detail

Event Timeline

krisb created this revision.Jan 16 2019, 7:47 AM
Herald added subscribers: llvm-commits, eraman. · View Herald TranscriptJan 16 2019, 7:47 AM
Harbormaster completed remote builds in B26910: Diff 182048.Jan 16 2019, 7:47 AM
asl accepted this revision.Jan 25 2019, 1:13 AM
This revision is now accepted and ready to land.Jan 25 2019, 1:13 AM
Closed by commit rL352178: [MSP430] Fix absolute addressing mode printing in AsmPrinter (authored by asl). · Explain WhyJan 25 2019, 1:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
MSP430/
4 lines
test/
CodeGen/
MSP430/
15 lines

Diff 182048

lib/Target/MSP430/MSP430AsmPrinter.cpp

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Lines
void MSP430AsmPrinter::printSrcMemOperand(const MachineInstr *MI, int OpNum, void MSP430AsmPrinter::printSrcMemOperand(const MachineInstr *MI, int OpNum,
raw_ostream &O) { raw_ostream &O) {
const MachineOperand &Base = MI->getOperand(OpNum); const MachineOperand &Base = MI->getOperand(OpNum);
const MachineOperand &Disp = MI->getOperand(OpNum+1); const MachineOperand &Disp = MI->getOperand(OpNum+1);
// Print displacement first // Print displacement first
// Imm here is in fact global address - print extra modifier. // Imm here is in fact global address - print extra modifier.
if (Disp.isImm() && !Base.getReg()) if (Disp.isImm() && Base.getReg() == MSP430::SR)
O << '&'; O << '&';
printOperand(MI, OpNum+1, O, "nohash"); printOperand(MI, OpNum+1, O, "nohash");
// Print register base field // Print register base field
if (Base.getReg()) { if (Base.getReg() != MSP430::SR && Base.getReg() != MSP430::PC) {
O << '('; O << '(';
printOperand(MI, OpNum, O); printOperand(MI, OpNum, O);
O << ')'; O << ')';
} }
} }
/// PrintAsmOperand - Print out an operand for an inline asm expression. /// PrintAsmOperand - Print out an operand for an inline asm expression.
/// ///
▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines

test/CodeGen/MSP430/inline-asm-absolute-addressing.ll

  • This file was added.
; RUN: llc < %s | FileCheck %s
; Check that absolute addressing mode is represented in a way
; defined in MSP430 EABI and not as indexed addressing mode form.
; See PR39993 for details.
target datalayout = "e-p:16:8:8-i8:8:8-i16:8:8-i32:8:8-n8:16"
target triple = "msp430-elf"
define void @f() {
entry:
; CHECK: mov r1, &256
call void asm sideeffect "mov r1, $0", "*m"(i8* inttoptr (i16 256 to i8*))
ret void
}