This is an archive of the discontinued LLVM Phabricator instance.

gn build: Make a couple of improvements to the unix toolchain.
ClosedPublic

Authored by pcc on Jan 14 2019, 9:14 PM.

Details

Summary

Add an asm tool (will be required for building sanitizer_common on
x64) and set a soname for DSOs so that anything that links against
them gets the correct DT_NEEDED.

Diff Detail

Event Timeline

pcc created this revision.Jan 14 2019, 9:14 PM
phosek added inline comments.Jan 14 2019, 11:01 PM
llvm/utils/gn/build/toolchain/BUILD.gn
44

This also needs {{asmflags}}.

pcc updated this revision to Diff 181730.Jan 14 2019, 11:49 PM
  • Address review comments
pcc marked 2 inline comments as done.Jan 14 2019, 11:49 PM
pcc added inline comments.
llvm/utils/gn/build/toolchain/BUILD.gn
44

Yes, also noticed that the description was wrong, fixed that too.

phosek accepted this revision.Jan 15 2019, 12:08 AM

LGTM

This revision is now accepted and ready to land.Jan 15 2019, 12:08 AM
This revision was automatically updated to reflect the committed changes.
pcc marked an inline comment as done.