This is an archive of the discontinued LLVM Phabricator instance.

gn build: Add a resource_dir.gni file.
ClosedPublic

Authored by pcc on Jan 14 2019, 8:29 PM.

Details

Summary

The path to the resource directory will end up being used in several
more places once the support for running check-hwasan lands. This
moves the definition to a central location so that it can be used
from those places.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc created this revision.Jan 14 2019, 8:29 PM
phosek added inline comments.Jan 14 2019, 8:52 PM
llvm/utils/gn/secondary/llvm/resource_dir.gni
3 ↗(On Diff #181709)

Shouldn't this be clang_resource_dir? clang/CMakeLists.txt defines this as CLANG_RESOURCE_DIR and so does clang/include/clang/Config/config.h, clang/lib/Driver/Driver.cpp and clang/lib/Frontend/CompilerInvocation.cpp.

pcc updated this revision to Diff 181729.Jan 14 2019, 11:31 PM
pcc marked 2 inline comments as done.
  • Rename to clang_resource_dir
llvm/utils/gn/secondary/llvm/resource_dir.gni
3 ↗(On Diff #181709)

Works for me, done.

phosek accepted this revision.Jan 15 2019, 12:08 AM

LGTM

This revision is now accepted and ready to land.Jan 15 2019, 12:08 AM
This revision was automatically updated to reflect the committed changes.