This is an archive of the discontinued LLVM Phabricator instance.

Differential D56645

[WebAssembly] Remove old intrinsics
ClosedPublic

Authored by sunfish on Jan 13 2019, 12:38 AM.

Details

Reviewers
sbc100
dschuff
aheejin
Commits
rG51532a524edc: [WebAssembly] Remove old builtins
rGbbb548d85f1d: [WebAssembly] Remove old intrinsics
rC351089: [WebAssembly] Remove old builtins
rL351089: [WebAssembly] Remove old builtins
rL351084: [WebAssembly] Remove old intrinsics
Summary

This removes the old grow_memory and mem.grow-style intrinsics, leaving just the memory.grow-style intrinsics.

The new intrinsics have been in place since 2018-05-31, and in this context I think this is enough time for compatibility.

Diff Detail

Repository
rL LLVM

Event Timeline

sunfish created this revision.Jan 13 2019, 12:38 AM
Herald added subscribers: llvm-commits, jgravelle-google. · View Herald TranscriptJan 13 2019, 12:38 AM
aheejin accepted this revision.Jan 13 2019, 12:32 PM
This revision is now accepted and ready to land.Jan 13 2019, 12:32 PM
dschuff accepted this revision.Jan 14 2019, 8:55 AM
Closed by commit rL351084: [WebAssembly] Remove old intrinsics (authored by djg). · Explain WhyJan 14 2019, 10:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
include/
llvm/
IR/
12 lines
lib/
Target/
WebAssembly/
29 lines

Diff 181592

llvm/trunk/include/llvm/IR/IntrinsicsWebAssembly.td

Show All 18 Lines
// respect to memory.grow calls. // respect to memory.grow calls.
def int_wasm_memory_size : Intrinsic<[llvm_anyint_ty], def int_wasm_memory_size : Intrinsic<[llvm_anyint_ty],
[llvm_i32_ty], [llvm_i32_ty],
[IntrReadMem]>; [IntrReadMem]>;
def int_wasm_memory_grow : Intrinsic<[llvm_anyint_ty], def int_wasm_memory_grow : Intrinsic<[llvm_anyint_ty],
[llvm_i32_ty, LLVMMatchType<0>], [llvm_i32_ty, LLVMMatchType<0>],
[]>; []>;
// These are the old names.
def int_wasm_mem_size : Intrinsic<[llvm_anyint_ty],
[llvm_i32_ty],
[IntrReadMem]>;
def int_wasm_mem_grow : Intrinsic<[llvm_anyint_ty],
[llvm_i32_ty, LLVMMatchType<0>],
[]>;
// These are the old old names. They also lack the immediate field.
def int_wasm_current_memory : Intrinsic<[llvm_anyint_ty], [], [IntrReadMem]>;
def int_wasm_grow_memory : Intrinsic<[llvm_anyint_ty], [LLVMMatchType<0>], []>;
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Saturating float-to-int conversions // Saturating float-to-int conversions
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
def int_wasm_trunc_saturate_signed : Intrinsic<[llvm_anyint_ty], def int_wasm_trunc_saturate_signed : Intrinsic<[llvm_anyint_ty],
[llvm_anyfloat_ty], [llvm_anyfloat_ty],
[IntrNoMem, IntrSpeculatable]>; [IntrNoMem, IntrSpeculatable]>;
def int_wasm_trunc_saturate_unsigned : Intrinsic<[llvm_anyint_ty], def int_wasm_trunc_saturate_unsigned : Intrinsic<[llvm_anyint_ty],
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines

llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrMemory.td

Show First 20 Lines • Show All 430 Lines • ▼ Show 20 Lines
// Current memory size. // Current memory size.
defm MEMORY_SIZE_I32 : I<(outs I32:$dst), (ins i32imm:$flags), defm MEMORY_SIZE_I32 : I<(outs I32:$dst), (ins i32imm:$flags),
(outs), (ins i32imm:$flags), (outs), (ins i32imm:$flags),
[(set I32:$dst, [(set I32:$dst,
(int_wasm_memory_size (i32 imm:$flags)))], (int_wasm_memory_size (i32 imm:$flags)))],
"memory.size\t$dst, $flags", "memory.size\t$flags", "memory.size\t$dst, $flags", "memory.size\t$flags",
0x3f>, 0x3f>,
Requires<[HasAddr32]>; Requires<[HasAddr32]>;
defm MEM_SIZE_I32 : I<(outs I32:$dst), (ins i32imm:$flags),
(outs), (ins i32imm:$flags),
[(set I32:$dst, (int_wasm_mem_size (i32 imm:$flags)))],
"mem.size\t$dst, $flags", "mem.size\t$flags", 0x3f>,
Requires<[HasAddr32]>;
defm CURRENT_MEMORY_I32 : I<(outs I32:$dst), (ins i32imm:$flags),
(outs), (ins i32imm:$flags),
[],
"current_memory\t$dst",
"current_memory\t$flags", 0x3f>,
Requires<[HasAddr32]>;
// Grow memory. // Grow memory.
defm MEMORY_GROW_I32 : I<(outs I32:$dst), (ins i32imm:$flags, I32:$delta), defm MEMORY_GROW_I32 : I<(outs I32:$dst), (ins i32imm:$flags, I32:$delta),
(outs), (ins i32imm:$flags), (outs), (ins i32imm:$flags),
[(set I32:$dst, [(set I32:$dst,
(int_wasm_memory_grow (i32 imm:$flags), (int_wasm_memory_grow (i32 imm:$flags),
I32:$delta))], I32:$delta))],
"memory.grow\t$dst, $flags, $delta", "memory.grow\t$dst, $flags, $delta",
"memory.grow\t$flags", 0x40>, "memory.grow\t$flags", 0x40>,
Requires<[HasAddr32]>; Requires<[HasAddr32]>;
defm MEM_GROW_I32 : I<(outs I32:$dst), (ins i32imm:$flags, I32:$delta),
(outs), (ins i32imm:$flags),
[(set I32:$dst,
(int_wasm_mem_grow (i32 imm:$flags), I32:$delta))],
"mem.grow\t$dst, $flags, $delta", "mem.grow\t$flags",
0x40>,
Requires<[HasAddr32]>;
defm GROW_MEMORY_I32 : I<(outs I32:$dst), (ins i32imm:$flags, I32:$delta),
(outs), (ins i32imm:$flags),
[],
"grow_memory\t$dst, $delta", "grow_memory\t$flags",
0x40>,
Requires<[HasAddr32]>;
def : Pat<(int_wasm_current_memory),
(CURRENT_MEMORY_I32 0)>;
def : Pat<(int_wasm_grow_memory I32:$delta),
(GROW_MEMORY_I32 0, $delta)>;