This is an archive of the discontinued LLVM Phabricator instance.

Isolate ARM and AArch64 Compiler-RT builds
ClosedPublic

Authored by rengolin on Oct 7 2014, 5:57 AM.

Download Raw Diff

Details

Reviewers

kcc
ygorshenin
eugenis

Summary

Right now, running tests on an ARM board makes the AArch64 tests execute automatically, which is not possible, since they're execution tests and ARM doesn't support AArch64 execution.

Diff Detail

Event Timeline

rengolin updated this revision to Diff 14506.Oct 7 2014, 5:57 AM

rengolin retitled this revision from to Isolate ARM and AArch64 Compiler-RT builds.

rengolin updated this object.

rengolin edited the test plan for this revision. (Show Details)

rengolin added reviewers: eugenis, kcc, ygorshenin.

rengolin set the repository for this revision to rL LLVM.

rengolin added a subscriber: Unknown Object (MLST).

Herald added a subscriber: aemerson. · View Herald TranscriptOct 7 2014, 5:57 AM

eugenis added inline comments.Oct 8 2014, 5:53 AM

cmake/config-ix.cmake
145–148	Did you mean "test_target_arch(aarch32" here?

Fixing copy&paste AArch32 error.

LGTM

This revision is now accepted and ready to land.Oct 8 2014, 6:01 AM

r219304, thanks!

cmake/config-ix.cmake
145–148	of course! :)

Revision Contents

Path

Size

cmake/

config-ix.cmake

9 lines

Diff 14567

cmake/config-ix.cmake

Context not available.
	test_target_arch(mips ${TARGET_32_BIT_CFLAGS})	test_target_arch(mips ${TARGET_32_BIT_CFLAGS})
	test_target_arch(mips64 ${TARGET_64_BIT_CFLAGS})	test_target_arch(mips64 ${TARGET_64_BIT_CFLAGS})
	endif()	endif()
	endif()	elseif("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES "arm")
	# Build ARM libraries if we are configured to test on ARM
	if("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES "arm\|aarch64")
	test_target_arch(arm "-march=armv7-a")	test_target_arch(arm "-march=armv7-a")
	test_target_arch(aarch64 "-march=armv8-a")	elseif("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES "aarch32")
		test_target_arch(aarch32 "-march=armv8-a")
		elseif("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES "aarch64")
		test_target_arch(aarch64 "-march=aarch64")
		eugenisUnsubmitted Not Done Reply Inline Actions Did you mean "test_target_arch(aarch32" here? eugenis: Did you mean "test_target_arch(aarch32" here?
		rengolinAuthorUnsubmitted Not Done Reply Inline Actions of course! :) rengolin: of course! :)
	endif()	endif()
	set(COMPILER_RT_OS_SUFFIX "")	set(COMPILER_RT_OS_SUFFIX "")
	endif()	endif()
Context not available.