After a discussion on the commit thread, it seems the 32 byte alignment
limitation is an MSVC toolchain artifact, not an inherent COFF
restriction. Clarify the comment accordingly, since saying COFF in the
comment but using isKnownWindowsMSVCEnvironment in the conditional is
confusing. Also add a newline before the comment, which is consistent
with the local style.
Details
Details
Diff Detail
Diff Detail
- Repository
- rC Clang
- Build Status
Buildable 26539 Build 26538: arc lint + arc unit
Event Timeline
lib/CodeGen/CodeGenModule.cpp | ||
---|---|---|
3765–3766 | I think it is most clear if this comment said "Microsoft's link.exe" instead of MSVC. |
Comment Actions
Refer to link.exe, and then also refer to other linkers in the second half of the comment to match
I think it is most clear if this comment said "Microsoft's link.exe" instead of MSVC.