Page MenuHomePhabricator

[CodeGen] Clarify comment about COFF common symbol alignment
ClosedPublic

Authored by smeenai on Jan 8 2019, 4:47 PM.

Details

Summary

After a discussion on the commit thread, it seems the 32 byte alignment
limitation is an MSVC toolchain artifact, not an inherent COFF
restriction. Clarify the comment accordingly, since saying COFF in the
comment but using isKnownWindowsMSVCEnvironment in the conditional is
confusing. Also add a newline before the comment, which is consistent
with the local style.

Diff Detail

Repository
rC Clang

Event Timeline

smeenai created this revision.Jan 8 2019, 4:47 PM
majnemer added inline comments.Jan 8 2019, 4:51 PM
lib/CodeGen/CodeGenModule.cpp
3765–3766

I think it is most clear if this comment said "Microsoft's link.exe" instead of MSVC.

smeenai updated this revision to Diff 180771.Jan 8 2019, 5:05 PM

Refer to link.exe, and then also refer to other linkers in the second half of the comment to match

This revision is now accepted and ready to land.Jan 8 2019, 11:09 PM
This revision was automatically updated to reflect the committed changes.