This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Quote the type of the leaked/problematic object in diagnostics for readability
ClosedPublic

Authored by george.karpenkov on Jan 4 2019, 5:26 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

NoQ accepted this revision.Jan 9 2019, 12:29 PM

Yup, i think it's a good thing to do in general.

clang/test/Analysis/osobject-retain-release.cpp
108 ↗(On Diff #180348)

an OSObject of type 'OSObject'

I'm... not surprised.

Should we filter those out explicitly? It seems that it's not an unusual case in practice.

This revision is now accepted and ready to land.Jan 9 2019, 12:29 PM

I'm... not surprised.

Not really, in practice those almost never appear, I just got lazy with tests.

NoQ added a comment.Jan 9 2019, 2:19 PM

My intuition has failed me then :)

This revision was automatically updated to reflect the committed changes.
cfe/trunk/test/Analysis/Inputs/expected-plists/objc-arc.m.plist