Page MenuHomePhabricator

[python] Make the collections import future-proof
ClosedPublic

Authored by jstasiak on Fri, Jan 4, 4:37 PM.

Details

Summary

On Python 3.7 the old code raises a warning:

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    class ArgumentsIterator(collections.Sequence):

On Python 3.8 it wouldn't work anymore.

Diff Detail

Repository
rC Clang

Event Timeline

jstasiak created this revision.Fri, Jan 4, 4:37 PM
This revision is now accepted and ready to land.Sat, Jan 5, 12:54 AM

Thanks. If you could commit this on my behalf I'd appreciate it (I don't have commit access).

Closed by commit rC350467: [python] Make the collections import future-proof (authored by serge_sans_paille, committed by ). · Explain WhySat, Jan 5, 4:11 AM
This revision was automatically updated to reflect the committed changes.