This is an archive of the discontinued LLVM Phabricator instance.

[Polly][Fix] Dead memory accesses should not confuse RTC generation
ClosedPublic

Authored by jdoerfert on Oct 6 2014, 5:16 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

jdoerfert updated this revision to Diff 14447.Oct 6 2014, 5:16 AM
jdoerfert retitled this revision from to [Polly][Fix] Dead memory accesses should not confuse RTC generation.
jdoerfert updated this object.
jdoerfert added subscribers: Restricted Project, Unknown Object (MLST).
simbuerg added inline comments.Oct 6 2014, 5:28 AM
lib/Analysis/ScopInfo.cpp
1278 ↗(On Diff #14447)

You are iterating over all memory accesses of one statement, so I assume MA->getStatement() is always equal to Stmt, right?
With that in mind, you can do the empty check outside this loop and skip the whole loop, if true.

Thanks, will be updated.

lib/Analysis/ScopInfo.cpp
1278 ↗(On Diff #14447)

100% correct... my bad.

jdoerfert closed this revision.Oct 6 2014, 10:53 AM
jdoerfert updated this revision to Diff 14464.

Closed by commit rL219131 (authored by @jdoerfert).