User Details
- User Since
- Jun 16 2014, 5:00 AM (483 w, 5 d)
Aug 28 2017
LGTM.
Aug 23 2017
Aug 18 2017
OK
Aug 16 2017
Apart from the Load/Store union_map issue and the tests, just a few minor remarks.
Aug 13 2017
We talked about it on Friday but I think I can help out more with a small writeup.
Aug 7 2017
Jul 25 2017
Jun 27 2017
Allright, I just committed the size-check with test. From my side this patch is ready as soon as:
- Rebase is done
- Commit message gives a usefull description of what this patch does.
We're getting close IMHO. I will commit the small range-check patch tonight.
Jun 26 2017
Jun 9 2017
Jun 7 2017
Jun 6 2017
So far it looks good. I would add tests that take care of error cases: negative sizes, overflow in the size calculation.
General Note: Can you reduce the size of the test-cases? (Remove the debug metadata with opt -strip-debug, unnecessary attributes).
May 23 2017
May 3 2017
Feb 24 2015
Otherwise LGTM.
Dec 19 2014
Nov 14 2014
Nov 13 2014
Nov 12 2014
Oct 14 2014
Alright, I got a closer second look and now I think it actually looks nicer than before ;-). Thanks for explaining.
Oct 13 2014
This is exactly what I feared.
I'm not sure if I'm the only one, but I really like the definition of the command-line options where they matter: In the file where they influence something. Why would we want to extract the definitions too? Isn't it sufficient to provide the Options.h header and be done with it (+unify the naming)?
LGTM
Oct 9 2014
Just a minor comment, I'm not fully awake yet. Btw, get some sleep! ;-)
Oct 6 2014
Aug 13 2014
I have some stylistic comments inline, the rest looks good to me.
LGTM.