Page MenuHomePhabricator

simbuerg (Andreas Simbuerger)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 16 2014, 5:00 AM (269 w, 6 d)

Recent Activity

Aug 28 2017

simbuerg accepted D37010: [Polly][PM] Properly require and preservation of OptimizationRemarkEmitter..

LGTM.

Aug 28 2017, 2:39 AM · Restricted Project

Aug 23 2017

simbuerg committed rL311619: [Polly][WIP] Scalar fully indexed expansion.
[Polly][WIP] Scalar fully indexed expansion
Aug 23 2017, 5:05 PM
simbuerg closed D36647: [Polly][WIP] Scalar fully indexed expansion by committing rL311619: [Polly][WIP] Scalar fully indexed expansion.
Aug 23 2017, 5:05 PM

Aug 18 2017

simbuerg committed rL311165: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion.
[Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion
Aug 18 2017, 8:03 AM
simbuerg closed D36791: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion by committing rL311165: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion.
Aug 18 2017, 8:03 AM
simbuerg accepted D36791: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion.

OK

Aug 18 2017, 7:57 AM

Aug 16 2017

simbuerg added a comment to D36791: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion.

Apart from the Load/Store union_map issue and the tests, just a few minor remarks.

Aug 16 2017, 9:41 AM

Aug 13 2017

simbuerg added a comment to D36647: [Polly][WIP] Scalar fully indexed expansion.

We talked about it on Friday but I think I can help out more with a small writeup.

Aug 13 2017, 5:56 PM

Aug 7 2017

simbuerg committed rL310304: [Polly] Fully-Indexed static expansion.
[Polly] Fully-Indexed static expansion
Aug 7 2017, 1:55 PM
simbuerg closed D34982: [Polly][WIP] Fully-Indexed static expansion by committing rL310304: [Polly] Fully-Indexed static expansion.
Aug 7 2017, 1:55 PM

Jul 25 2017

simbuerg added inline comments to D34982: [Polly][WIP] Fully-Indexed static expansion.
Jul 25 2017, 9:18 AM

Jun 27 2017

simbuerg added a comment to D33688: [Polly] Heap allocation for new arrays.

Allright, I just committed the size-check with test. From my side this patch is ready as soon as:

  • Rebase is done
  • Commit message gives a usefull description of what this patch does.
Jun 27 2017, 3:36 PM
simbuerg added a comment to D33688: [Polly] Heap allocation for new arrays.

We're getting close IMHO. I will commit the small range-check patch tonight.

Jun 27 2017, 7:48 AM
simbuerg added inline comments to D33688: [Polly] Heap allocation for new arrays.
Jun 27 2017, 5:10 AM
simbuerg added inline comments to D33688: [Polly] Heap allocation for new arrays.
Jun 27 2017, 4:41 AM
simbuerg committed rL306398: [NFC][CodeGen] Use the ExitBlock explicitly..
[NFC][CodeGen] Use the ExitBlock explicitly.
Jun 27 2017, 4:33 AM
simbuerg committed rL306395: [FIX] Add %loadPolly to test.
[FIX] Add %loadPolly to test
Jun 27 2017, 3:48 AM
simbuerg added inline comments to D33688: [Polly] Heap allocation for new arrays.
Jun 27 2017, 1:45 AM

Jun 26 2017

simbuerg committed rL306283: [NFC] Return both polly.start and polly.exiting from executeScopConditionally..
[NFC] Return both polly.start and polly.exiting from executeScopConditionally.
Jun 26 2017, 5:17 AM
simbuerg added inline comments to D33688: [Polly] Heap allocation for new arrays.
Jun 26 2017, 3:12 AM
simbuerg added inline comments to D33688: [Polly] Heap allocation for new arrays.
Jun 26 2017, 3:00 AM

Jun 9 2017

simbuerg added inline comments to D33688: [Polly] Heap allocation for new arrays.
Jun 9 2017, 2:06 AM
simbuerg added inline comments to D33688: [Polly] Heap allocation for new arrays.
Jun 9 2017, 2:03 AM

Jun 7 2017

simbuerg added inline comments to D33688: [Polly] Heap allocation for new arrays.
Jun 7 2017, 5:12 AM

Jun 6 2017

simbuerg added inline comments to D33688: [Polly] Heap allocation for new arrays.
Jun 6 2017, 9:19 AM
simbuerg added a comment to D33688: [Polly] Heap allocation for new arrays.

So far it looks good. I would add tests that take care of error cases: negative sizes, overflow in the size calculation.

Jun 6 2017, 8:58 AM
simbuerg added inline comments to D33688: [Polly] Heap allocation for new arrays.
Jun 6 2017, 8:54 AM
simbuerg added a comment to D33688: [Polly] Heap allocation for new arrays.

General Note: Can you reduce the size of the test-cases? (Remove the debug metadata with opt -strip-debug, unnecessary attributes).

Jun 6 2017, 8:46 AM

May 23 2017

simbuerg added inline comments to rL303631: [NFC] [PolyhedralInfo] fix typo.
May 23 2017, 4:56 AM

May 3 2017

simbuerg added inline comments to D32739: [Polly] JSONImporter misses checks whether the data it imports makes sense..
May 3 2017, 3:35 AM

Feb 24 2015

simbuerg added a comment to D7846: Allow non-affine control flow -- SCoP Modeling.

Otherwise LGTM.

Feb 24 2015, 1:50 AM
simbuerg added inline comments to D7829: Allow non-affine control flow -- SCoP Detection.
Feb 24 2015, 1:28 AM

Dec 19 2014

simbuerg committed rL224591: (diagnostics) fix typo in test....
(diagnostics) fix typo in test...
Dec 19 2014, 9:23 AM
simbuerg committed rL224584: (diagnostics) Fix typo..
(diagnostics) Fix typo.
Dec 19 2014, 8:50 AM

Nov 14 2014

simbuerg accepted D5517: [Polly] [IslCodeGenerator] Add OpenMP support.
Nov 14 2014, 7:09 AM

Nov 13 2014

simbuerg added inline comments to D5517: [Polly] [IslCodeGenerator] Add OpenMP support.
Nov 13 2014, 10:57 PM

Nov 12 2014

simbuerg added inline comments to D6232: Demo (Proof of Concept) of isl++.
Nov 12 2014, 3:58 PM
simbuerg retitled D6232: Demo (Proof of Concept) of isl++ from to Demo (Proof of Concept) of isl++.
Nov 12 2014, 11:26 AM

Oct 14 2014

simbuerg added a comment to D5762: [Polly][Unfinished][NFC] Restructure the command line options.

Alright, I got a closer second look and now I think it actually looks nicer than before ;-). Thanks for explaining.

Oct 14 2014, 5:35 AM

Oct 13 2014

simbuerg added a comment to D5762: [Polly][Unfinished][NFC] Restructure the command line options.

This is exactly what I feared.
I'm not sure if I'm the only one, but I really like the definition of the command-line options where they matter: In the file where they influence something. Why would we want to extract the definitions too? Isn't it sufficient to provide the Options.h header and be done with it (+unify the naming)?

Oct 13 2014, 11:05 PM
simbuerg accepted D5747: [Polly] Implemented Condition::print(raw_ostream &OS).

LGTM

Oct 13 2014, 12:13 AM

Oct 9 2014

simbuerg added a comment to D4988: [Polly] Extract number of elements/iterations for a isl_set/isl_ast_node.

Just a minor comment, I'm not fully awake yet. Btw, get some sleep! ;-)

Oct 9 2014, 10:45 PM

Oct 6 2014

simbuerg added inline comments to D5623: [Polly][Fix] Dead memory accesses should not confuse RTC generation.
Oct 6 2014, 5:28 AM

Aug 13 2014

simbuerg added a comment to D4843: [Polly] Added support for modulo accesses.

I have some stylistic comments inline, the rest looks good to me.

Aug 13 2014, 2:49 PM · Restricted Project
simbuerg added a comment to D4871: [Polly] Remove the PoCC and ScopLib support.

LGTM.

Aug 13 2014, 3:12 AM

Jun 26 2014

simbuerg closed D4171: [polly] Support the new DiagnosticRemarks.

Closed by commit rL211769 (authored by @simbuerg).

Jun 26 2014, 3:15 AM

Jun 17 2014

simbuerg retitled D4171: [polly] Support the new DiagnosticRemarks from to [polly] Support the new DiagnosticRemarks.
Jun 17 2014, 1:39 AM