Symtab: Remove one copy of symbol size computation code

[labath]

Summary

The implementation in CalculateSymbolSizes has been made redundant in
D19004, as this patch added another copy of size computation code into
InitAddressIndexes (which is called by CalculateSymbolSizes).

lldb/trunk/source/Symbol/Symtab.cpp

if (num_entries > 0) {
       // Sort again in case the range size changes the ordering
       m_file_addr_to_index.Sort();
     }
   }
 }
 
 void Symtab::CalculateSymbolSizes() {
   std::lock_guard<std::recursive_mutex> guard(m_mutex);
-
-  if (!m_symbols.empty()) {
-    if (!m_file_addr_to_index_computed)
-      InitAddressIndexes();
-
-    const size_t num_entries = m_file_addr_to_index.GetSize();
-
-    for (size_t i = 0; i < num_entries; ++i) {
-      // The entries in the m_file_addr_to_index have calculated the sizes
-      // already so we will use this size if we need to.
-      const FileRangeToIndexMap::Entry &entry =
-          m_file_addr_to_index.GetEntryRef(i);
-
-      Symbol &symbol = m_symbols[entry.data];
-
-      // If the symbol size is already valid, no need to do anything
-      if (symbol.GetByteSizeIsValid())
-        continue;
-
-      const addr_t range_size = entry.GetByteSize();
-      if (range_size > 0) {
-        symbol.SetByteSize(range_size);
-        symbol.SetSizeIsSynthesized(true);
-      }
-    }
-  }
+  // Size computation happens inside InitAddressIndexes.
 }
 
 Symbol *Symtab::FindSymbolAtFileAddress(addr_t file_addr) {
   std::lock_guard<std::recursive_mutex> guard(m_mutex);
   if (!m_file_addr_to_index_computed)
     InitAddressIndexes();
 
   const FileRangeToIndexMap::Entry *entry =