Page MenuHomePhabricator

[OPENMP][NVPTX]Outline assert into noinline function, NFC.
ClosedPublic

Authored by ABataev on Dec 27 2018, 7:01 AM.

Details

Summary

At high optimization level asserts lead to some unexpected results
because of auto-inserted unreachable instructions. This outlining
prevents some of such dangerous optimizations and leads to better
stability.

Diff Detail

Repository
rL LLVM

Event Timeline

ABataev created this revision.Dec 27 2018, 7:01 AM
grokos accepted this revision.Dec 27 2018, 8:15 AM

Looks good.

This revision is now accepted and ready to land.Dec 27 2018, 8:15 AM
This revision was automatically updated to reflect the committed changes.